Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FormatFStringPart #14448

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Remove FormatFStringPart #14448

merged 1 commit into from
Nov 25, 2024

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 19, 2024

Summary

This is just a small refactor to remove the FormatFStringPart as it's only used in the case when the f-string is not implicitly concatenated in which case the only part is going to be FString. In implicitly concatenated f-strings, we use StringLike instead.

@dhruvmanila dhruvmanila added the formatter Related to the formatter label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

ruff-ecosystem results

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Nov 21, 2024
@dhruvmanila dhruvmanila marked this pull request as ready for review November 21, 2024 11:17
@dhruvmanila dhruvmanila merged commit efe5408 into main Nov 25, 2024
20 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/f-string-assignment-1 branch November 25, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants