[flake8-pyi] Avoid rewriting invalid type expressions in unnecessary-type-union (PYI055)
#14660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrugman
commented
Nov 28, 2024
| // a single parameter. This likely is a confusion with `type[a | b]` or | ||
| // `type[Union[a, b]]`. Do not emit a diagnostic for invalid type | ||
| // annotations. | ||
| if semantic.match_builtin_expr(value, "type") && !matches!(**slice, Expr::Tuple(_)) |
There was a problem hiding this comment.
The user should be notified, but we can leave that for the type checker.
AlexWaygood
approved these changes
Nov 28, 2024
crates/ruff_linter/src/rules/flake8_pyi/rules/unnecessary_type_union.rs
Outdated
Show resolved
Hide resolved
…_union.rs Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
dhruvmanila
changed the title
flake8-pyi] Avoid rewriting invalid type expressions in unnecessary-type-union (PYI055)flake8-pyi] Avoid rewriting invalid type expressions in unnecessary-type-union (PYI055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See this discussion for details #14641 (comment)
Test Plan
Updated the test fixtures to have valid
typeannotations, and appended the invalidtypeannotations as check.