[airflow]: extend removed method class attributes and more methods (AIR302) #15083
+828
−476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any class in Airflow that inherits these class should not have these methods * `airflow.secrets.base_secrets.BaseSecretsBackend.get_conn_uri` → `airflow.secrets.base_secrets.BaseSecretsBackend.get_conn_value` * `airflow.secrets.base_secrets.BaseSecretsBackend.get_connections` → `airflow.secrets.base_secrets.BaseSecretsBackend.get_connection` * `airflow.hooks.base.BaseHook.get_connections` → use `get_connection` * `airflow.datasets.BaseDataset.iter_datasets` → `airflow.sdk.definitions.asset.BaseAsset.iter_assets` * `airflow.datasets.BaseDataset.iter_dataset_aliases` → `airflow.sdk.definitions.asset.BaseAsset.iter_asset_aliases`
Lee-W
changed the title
MichaReiser
reviewed
Dec 20, 2024
Comment on lines
+255
to
+259
| _ if SECRET_BACKEND_REGEX.is_match(&qualname.segments().join(".")) => match attr.as_str() { | ||
| "get_conn_uri" => Some(Replacement::Name("get_conn_value")), | ||
| "get_connections" => Some(Replacement::Name("get_connection")), | ||
| &_ => None, | ||
| }, |
There was a problem hiding this comment.
It should be possible to simplify the regex a bit (to ensure it runs less frequently?)
Suggested change
| _ if SECRET_BACKEND_REGEX.is_match(&qualname.segments().join(".")) => match attr.as_str() { | |
| "get_conn_uri" => Some(Replacement::Name("get_conn_value")), | |
| "get_connections" => Some(Replacement::Name("get_connection")), | |
| &_ => None, | |
| }, | |
| ["airflow", rest @ ..] if SECRET_BACKEND_REGEX.is_match(rest.join(".")) => match attr.as_str() { | |
| "get_conn_uri" => Some(Replacement::Name("get_conn_value")), | |
| "get_connections" => Some(Replacement::Name("get_connection")), | |
| &_ => None, | |
| }, |
This requires removing the airflow segment from the regex. The advantage is that we can skip over the match if the first segment isn't airflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Airflow 3.0 removes various deprecated functions, members, modules, and other values. They have been deprecated in 2.x, but the removal causes incompatibilities that we want to detect. This PR deprecates the following methods and add a function for removed class attributes
airflow.providers_manager.ProvidersManager.dataset_factories→airflow.providers_manager.ProvidersManager.asset_factoriesairflow.providers_manager.ProvidersManager.dataset_uri_handlers→airflow.providers_manager.ProvidersManager.asset_uri_handlersairflow.providers_manager.ProvidersManager.dataset_to_openlineage_converters→airflow.providers_manager.ProvidersManager.asset_to_openlineage_convertersairflow.lineage.hook.DatasetLineageInfo.dataset→airflow.lineage.hook.AssetLineageInfo.assetAny class in Airflow that inherits these class should not have these methods
airflow.secrets.base_secrets.BaseSecretsBackend.get_conn_uri→airflow.secrets.base_secrets.BaseSecretsBackend.get_conn_valueairflow.secrets.base_secrets.BaseSecretsBackend.get_connections→airflow.secrets.base_secrets.BaseSecretsBackend.get_connectionairflow.hooks.base.BaseHook.get_connections→ useget_connectionairflow.datasets.BaseDataset.iter_datasets→airflow.sdk.definitions.asset.BaseAsset.iter_assetsairflow.datasets.BaseDataset.iter_dataset_aliases→airflow.sdk.definitions.asset.BaseAsset.iter_asset_aliasesTest Plan
A test fixture is included in the PR.