Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastapi] Handle parameters with Depends correctly (FAST003) #15364

Merged
merged 11 commits into from
Jan 13, 2025
Merged

[fastapi] Handle parameters with Depends correctly (FAST003) #15364

merged 11 commits into from
Jan 13, 2025

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #13657.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh self-assigned this Jan 9, 2025
MichaReiser
MichaReiser requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A few comments related to how the code is structured and the used terminology

@MichaReiser MichaReiser added the rule Implementing or modifying a lint rule label Jan 9, 2025
@dhruvmanila dhruvmanila added the preview Related to preview mode features label Jan 9, 2025
MichaReiser
MichaReiser approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. One small nit and an understand question from my end.

@charliermarsh charliermarsh removed their assignment Jan 9, 2025
@charliermarsh
Copy link
Member

I'll let @MichaReiser merge but I removed all the string allocations.

@MichaReiser MichaReiser enabled auto-merge (squash) January 13, 2025 08:46
@MichaReiser MichaReiser merged commit 6f35a4d into astral-sh:main Jan 13, 2025
20 checks passed
@InSyncWithFoo InSyncWithFoo deleted the FAST003 branch January 13, 2025 08:53
@BrewTestBot BrewTestBot mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@charliermarsh charliermarsh charliermarsh left review comments

@tiangolo tiangolo tiangolo left review comments

Assignees
No one assigned
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAST003 doesn't detect params used in injected dependencies
5 participants
@InSyncWithFoo @charliermarsh @MichaReiser @tiangolo @dhruvmanila