Fix __init__.py being private
#1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind expanding the PR summary a bit to flesh out what changed here and why? |
Previously visibility::module_visibility() returned Private for any module name starting with an underscore, resulting in __init__.py being categorized as private, which in turn resulted in D104 (Missing docstring in public package) never being reported for __init__.py files. This commit fixes this by accounting for __init__.py.
Any string that starts with __ also starts with _ so the latter part of the expression was redundant.
not-my-profile
force-pushed
the
fix-__init__.py-being-private
branch
from
70151ce
to
065863c
Compare
|
But of course :) I amended the commit messages and the PR description. |
|
Thank you :) |
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jan 3, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.206` -> `^0.0.207` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.207`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.207) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.206...v0.0.207) #### What's Changed - Implement list-to-tuple comprehension unpacking by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/1534](https://togithub.com/charliermarsh/ruff/pull/1534) - Avoid triggering PD errors on method calls by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1537](https://togithub.com/charliermarsh/ruff/pull/1537) - Avoid PD false positives on some non-DataFrame expressions by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1538](https://togithub.com/charliermarsh/ruff/pull/1538) - Correct UP027 message to “generator expression” by [@​andersk](https://togithub.com/andersk) in [https://github.com/charliermarsh/ruff/pull/1540](https://togithub.com/charliermarsh/ruff/pull/1540) - Add flake8-simplify SIM300 check for Yoda Conditions by [@​PedramNavid](https://togithub.com/PedramNavid) in [https://github.com/charliermarsh/ruff/pull/1539](https://togithub.com/charliermarsh/ruff/pull/1539) - Print warning when running debug builds without --no-cache by [@​not-my-profile](https://togithub.com/not-my-profile) in [https://github.com/charliermarsh/ruff/pull/1549](https://togithub.com/charliermarsh/ruff/pull/1549) - Fix typing::match_annotated_subscript matching ExprKind::Call by [@​not-my-profile](https://togithub.com/not-my-profile) in [https://github.com/charliermarsh/ruff/pull/1554](https://togithub.com/charliermarsh/ruff/pull/1554) - Add clarification by [@​VictorGob](https://togithub.com/VictorGob) in [https://github.com/charliermarsh/ruff/pull/1557](https://togithub.com/charliermarsh/ruff/pull/1557) - Add explicit new-rule recommendation in CONTRIBUTING.md by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1558](https://togithub.com/charliermarsh/ruff/pull/1558) - Detect unpacking assignments in eradicate by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1559](https://togithub.com/charliermarsh/ruff/pull/1559) - Fix `__init__.py` being private by [@​not-my-profile](https://togithub.com/not-my-profile) in [https://github.com/charliermarsh/ruff/pull/1556](https://togithub.com/charliermarsh/ruff/pull/1556) #### New Contributors - [@​PedramNavid](https://togithub.com/PedramNavid) made their first contribution in [https://github.com/charliermarsh/ruff/pull/1539](https://togithub.com/charliermarsh/ruff/pull/1539) - [@​VictorGob](https://togithub.com/VictorGob) made their first contribution in [https://github.com/charliermarsh/ruff/pull/1557](https://togithub.com/charliermarsh/ruff/pull/1557) **Full Changelog**: astral-sh/ruff@v0.0.206...v0.0.207 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
visibility::module_visibility()returnedPrivatefor any module name starting with an underscore, resulting in
__init__.pybeing categorized as private, which in turn resultedin D104 (Missing docstring in public package) never being reported
for
__init__.pyfiles.The commits implement separate changes, so I'd rather have you not squash them.