[flake8-simplify] Avoid double negations (SIM103)

[InSyncWithFoo]

Summary

Related to this comment at #6184.

Test Plan

cargo nextest run and cargo insta test.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+8 -8 violations, +0 -0 fixes in 3 projects; 52 projects unchanged)

apache/airflow (+5 -5 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- airflow/configuration.py:1259:13: SIM103 Return the condition `not value is None` directly
+ airflow/configuration.py:1259:13: SIM103 Return the condition `value is not None` directly
- providers/src/airflow/providers/amazon/aws/sensors/athena.py:94:9: SIM103 Return the condition `not state in self.INTERMEDIATE_STATES` directly
+ providers/src/airflow/providers/amazon/aws/sensors/athena.py:94:9: SIM103 Return the condition `state not in self.INTERMEDIATE_STATES` directly
- providers/src/airflow/providers/amazon/aws/sensors/emr.py:316:9: SIM103 Return the condition `not state in self.INTERMEDIATE_STATES` directly
+ providers/src/airflow/providers/amazon/aws/sensors/emr.py:316:9: SIM103 Return the condition `state not in self.INTERMEDIATE_STATES` directly
- providers/src/airflow/providers/amazon/aws/sensors/opensearch_serverless.py:110:9: SIM103 Return the condition `not state in self.INTERMEDIATE_STATES` directly
+ providers/src/airflow/providers/amazon/aws/sensors/opensearch_serverless.py:110:9: SIM103 Return the condition `state not in self.INTERMEDIATE_STATES` directly
+ scripts/ci/pre_commit/check_integrations_list.py:113:9: SIM103 Return the condition `j not in ["Description", "Identifier"]` directly
- scripts/ci/pre_commit/check_integrations_list.py:113:9: SIM103 Return the condition `not j in ["Description", "Identifier"]` directly

apache/superset (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- superset/commands/importers/v1/utils.py:204:5: SIM103 Return the condition `not path.suffix.lower() not in {".yaml", ".yml"}` directly
+ superset/commands/importers/v1/utils.py:204:5: SIM103 Return the condition `path.suffix.lower() in {".yaml", ".yml"}` directly

zulip/zulip (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- zerver/lib/message.py:1539:5: SIM103 Return the condition `not user_profile.realm != message.get_realm()` directly
+ zerver/lib/message.py:1539:5: SIM103 Return the condition `user_profile.realm == message.get_realm()` directly
+ zerver/views/custom_profile_fields.py:82:5: SIM103 Return the condition `field_data["subtype"] != "custom"` directly
- zerver/views/custom_profile_fields.py:82:5: SIM103 Return the condition `not field_data["subtype"] == "custom"` directly

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
SIM103	16	8	8	0	0

[dylwil3]

Thanks! This looks great, but let's gate it behind preview in case there's something we're missing. After doing so, you'll have to add a note to the documentation about the fix behavior under preview.

[dylwil3]

Great, thank you!