Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatter warning message for flake8-quotes option #15788

Merged

Conversation

marekhanus
Copy link
Contributor

@marekhanus marekhanus commented Jan 28, 2025

Summary

Fix wrong option name in warning message about docstring quotes incompatibility.

Test Plan

Only in CI. No manual testing.

@marekhanus marekhanus force-pushed the feature/docstring_quotes_message branch from 7f50128 to 5ffe1e6 Compare January 28, 2025 17:59
@marekhanus marekhanus force-pushed the feature/docstring_quotes_message branch from 5ffe1e6 to d0fbd35 Compare January 28, 2025 18:10
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@marekhanus marekhanus marked this pull request as ready for review January 28, 2025 19:31
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dhruvmanila dhruvmanila added the cli Related to the command-line interface label Jan 29, 2025
@dhruvmanila dhruvmanila changed the title fix: docstring quotes warning message Fix formatter warning message for flake8-quotes option Jan 29, 2025
@dhruvmanila dhruvmanila merged commit 2c3d889 into astral-sh:main Jan 29, 2025
21 checks passed
dcreager added a commit that referenced this pull request Jan 29, 2025
* main:
  [red-knot] Extend instance-attribute tests (#15808)
  Fix formatter warning message for `flake8-quotes` option (#15788)
  [`flake8-bugbear`] Exempt `NewType` calls where the original type is immutable (`B008`) (#15765)
  Add missing config docstrings (#15803)
  [`refurb`] Do not emit diagnostic when loop variables are used outside loop body (`FURB122`) (#15757)
  [`ruff`] Check for shadowed `map` before suggesting fix (`RUF058`) (#15790)
  [red-knot] Do not use explicit `knot_extensions.Unknown` declaration (#15787)
  Preserve quotes in generated byte strings (#15778)
  [minor] Simplify some `ExprStringLiteral` creation logic (#15775)
  Preserve quote style in generated code (#15726)
  Rename internal helper functions (#15771)
  [`airflow`] Extend airflow context parameter check for `BaseOperator.execute` (`AIR302`) (#15713)
  Implement tab autocomplete for `ruff config` (#15603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants