[pylint] Correct ordering of arguments in fix for if-stmt-min-max (PLR1730)

[VascoSch92]

The PR addresses the issue #16040 .

---

The logic used into the rule is the following:

Suppose to have an expression of the form

if a cmp b:
    c = d

where a, b, c and d are Python obj and cmp one of <, >, <=, >=.

Then:

• if a=c and b=d

  • if <= fix with a = max(b, a)
  • if >= fix with a = min(b, a)
  • if > fix with a = min(a, b)
  • if < fix with a = max(a, b)

• if a=d and b=c

  • if <= fix with b = min(a, b)
  • if >= fix with b = max(a, b)
  • if > fix with b = max(b, a)
  • if < fix with b = min(b, a)

• do nothing, i.e., we cannot fix this case.

---

In total we have 8 different and possible cases.

| Case  | Expression       | Fix           |
|-------|------------------|---------------|
| 1     | if a >= b: a = b | a = min(b, a) |
| 2     | if a <= b: a = b | a = max(b, a) |
| 3     | if a <= b: b = a | b = min(a, b) |
| 4     | if a >= b: b = a | b = max(a, b) |
| 5     | if a > b: a = b  | a = min(a, b) |
| 6     | if a < b: a = b  | a = max(a, b) |
| 7     | if a < b: b = a  | b = min(b, a) |
| 8     | if a > b: b = a  | b = max(b, a) |

I added them in the tests.

Please double-check that I didn't make any mistakes. It's quite easy to mix up > and <.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[MichaReiser]

I think this is incorrect and should instead be false to match your table from the PR summary.

Please also carefully review the snapshot changes.

[VascoSch92]

In this case where are in the situation:

if a <= b:
    b = a

which is fixed by b = min(a, b).

So you are right ;-)

Please also carefully review the snapshot changes.

I corrected the snapshot and I double-checked all the other changes I did. Everything follow the table posted in the description of the PR.

[MichaReiser]

Thank you