document MSRV policy #16384
document MSRV policy #16384
Conversation
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
LGTM. This is now stricter than what I had in mind as it disallows us to use a newer MSRV than stable - 2 -- without exception. I wonder if we should relax the phrasing to leave us some wiggle room.
|
That was my understanding of the commitment we were making to downstream. If redistributors can't count on having those two releases' time to catch up, then I'm not sure what the value is of documenting N-2 as a policy? I'll go with whatever we agree on here, but to me that seems like a significant change that I'd want to be sure we're aligned on beyond just the two of us. |
I was mainly looking to document that MSRV bumps aren't considered breaking in terms of semver. Not breaking downstream packagers is in our own interest |
|
My opinion is that the best way to not break downstream packagers is to set a clear policy and stick to it. If we plan to do N-2, I think that should be documented somewhere, just for the benefit of future-us remembering what we decided, if nothing else. If you'd like to propose a different version of this PR, maybe it would be simplest for you to put up an alternative PR? |
|
As I said. I'm okay with the current version. It simply means that we no longer have the option to make an exception |
|
Ok, will go ahead and land for now. If you feel it's important that we carve out an option for exceptions, we can discuss and consider that as a separate change. |
* main: [red-knot] unify LoopState and saved_break_states (#16406) [`pylint`] Also reports `case np.nan`/`case math.nan` (`PLW0177`) (#16378) [FURB156] Do not consider docstring(s) (#16391) Use `is_none_or` in `stdlib-module-shadowing` (#16402) [red-knot] Upgrade salsa to include `AtomicPtr` perf improvement (#16398) [red-knot] Fix file watching for new non-project files (#16395) document MSRV policy (#16384) [red-knot] fix non-callable reporting for unions (#16387) bump MSRV to 1.83 (#16294) Avoid unnecessary info at non-trace server log level (#16389) Expand `ruff.configuration` to allow inline config (#16296) Start detecting version-related syntax errors in the parser (#16090)
* dcreager/dont-have-a-cow: [red-knot] unify LoopState and saved_break_states (#16406) [`pylint`] Also reports `case np.nan`/`case math.nan` (`PLW0177`) (#16378) [FURB156] Do not consider docstring(s) (#16391) Use `is_none_or` in `stdlib-module-shadowing` (#16402) [red-knot] Upgrade salsa to include `AtomicPtr` perf improvement (#16398) [red-knot] Fix file watching for new non-project files (#16395) document MSRV policy (#16384) [red-knot] fix non-callable reporting for unions (#16387) bump MSRV to 1.83 (#16294) Avoid unnecessary info at non-trace server log level (#16389) Expand `ruff.configuration` to allow inline config (#16296) Start detecting version-related syntax errors in the parser (#16090)
* main: [red-knot] unify LoopState and saved_break_states (#16406) [`pylint`] Also reports `case np.nan`/`case math.nan` (`PLW0177`) (#16378) [FURB156] Do not consider docstring(s) (#16391) Use `is_none_or` in `stdlib-module-shadowing` (#16402) [red-knot] Upgrade salsa to include `AtomicPtr` perf improvement (#16398) [red-knot] Fix file watching for new non-project files (#16395) document MSRV policy (#16384) [red-knot] fix non-callable reporting for unions (#16387) bump MSRV to 1.83 (#16294) Avoid unnecessary info at non-trace server log level (#16389) Expand `ruff.configuration` to allow inline config (#16296) Start detecting version-related syntax errors in the parser (#16090)
## Summary Copying astral-sh/ruff#16384 over to uv.
This documents our minimum supported Rust version policy. See #16370