Skip to content

Conversation

@VascoSch92
Copy link
Contributor

This PR (partially) addresses issue #16373

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -2 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

bokeh/bokeh (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

- src/bokeh/command/subcommands/serve.py:1002:1: A001 Variable `__doc__` is shadowing a Python builtin
- src/bokeh/util/serialization.py:89:1: A001 Variable `__doc__` is shadowing a Python builtin

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
A001 2 0 2 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -2 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

bokeh/bokeh (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- src/bokeh/command/subcommands/serve.py:1002:1: A001 Variable `__doc__` is shadowing a Python builtin
- src/bokeh/util/serialization.py:89:1: A001 Variable `__doc__` is shadowing a Python builtin

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
A001 2 0 2 0 0

@MichaReiser MichaReiser changed the title [flake8-builtins] Exclude Variables Matching Module Attribute Names from Violation Reports (A001) [flake8-builtins] Exclude Variables Matching Module Attribute Names (A001) Mar 3, 2025
@MichaReiser MichaReiser changed the title [flake8-builtins] Exclude Variables Matching Module Attribute Names (A001) [flake8-builtins] Ignore variables matching module attribute names (A001) Mar 3, 2025
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MichaReiser MichaReiser added bug Something isn't working rule Implementing or modifying a lint rule labels Mar 3, 2025
@MichaReiser MichaReiser merged commit 5d56c2e into astral-sh:main Mar 3, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants