-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[flake8-comprehensions] Stabilize unnecessary-dict-comprehension-for-iterable (C420)
#16624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-iterable` (`C420`)
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| C420 | 57 | 57 | 0 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
Contributor
Author
|
All of the ecosystem results look like true positives to me. |
MichaReiser
approved these changes
Mar 11, 2025
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
…or-iterable` (`C420`) (#16624) ## Summary Stabilizes C420 for the 0.10 release. ## Test Plan No open issues or PRs (except a general issue about [string normalization](#16579)). The last (and only) false-negative bug fix was over a month ago. The tests for this rule were already not on the `preview_rules` test, so I just changed the `RuleGroup`. The documentation looked okay to me.
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
…or-iterable` (`C420`) (#16624) ## Summary Stabilizes C420 for the 0.10 release. ## Test Plan No open issues or PRs (except a general issue about [string normalization](#16579)). The last (and only) false-negative bug fix was over a month ago. The tests for this rule were already not on the `preview_rules` test, so I just changed the `RuleGroup`. The documentation looked okay to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes C420 for the 0.10 release.
Test Plan
No open issues or PRs (except a general issue about string normalization). The last (and only) false-negative bug fix was over a month ago.
The tests for this rule were already not on the
preview_rulestest, so I just changed theRuleGroup. The documentation looked okay to me.