Skip to content

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Mar 12, 2025

Summary

Stabilizes PTH210. Tests and docs looked good.

Test Plan

Mentioned in 1 open issue around Python 3.14 support ("." becomes a valid suffix in 3.14). Otherwise no issues or PRs since 2024-12-12, 6 days after the rule was added.

@ntBre ntBre added the rule Implementing or modifying a lint rule label Mar 12, 2025
@ntBre ntBre added this to the v0.10 milestone Mar 12, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #16656 will degrade performances by 4.6%

Comparing brent/pth210-0.10 (e94bf05) with micha/ruff-0.10 (464ea4a)

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
red_knot_check_file[incremental] 5.2 ms 5.5 ms -4.6%

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre mentioned this pull request Mar 12, 2025
2 tasks
…10`)

Summary
--

Stabilizes PTH210. Tests and docs looked good.

Test Plan
--

Mentioned in 1 open issue around Python 3.14 support (`"."` becomes a valid
suffix in 3.14). Otherwise no issues or PRs since 2024-12-12, 6 days after the
rule was added.
@ntBre ntBre force-pushed the brent/pth210-0.10 branch from fd2cb69 to e94bf05 Compare March 12, 2025 16:59
@ntBre ntBre merged commit 7bc8bb2 into micha/ruff-0.10 Mar 12, 2025
20 of 21 checks passed
@ntBre ntBre deleted the brent/pth210-0.10 branch March 12, 2025 17:07
MichaReiser pushed a commit that referenced this pull request Mar 13, 2025
…10`) (#16656)

Summary
--

Stabilizes PTH210. Tests and docs looked good.

Test Plan
--

Mentioned in 1 open issue around Python 3.14 support (`"."` becomes a
valid suffix in 3.14). Otherwise no issues or PRs since 2024-12-12, 6
days after the rule was added.
MichaReiser pushed a commit that referenced this pull request Mar 13, 2025
…10`) (#16656)

Summary
--

Stabilizes PTH210. Tests and docs looked good.

Test Plan
--

Mentioned in 1 open issue around Python 3.14 support (`"."` becomes a
valid suffix in 3.14). Otherwise no issues or PRs since 2024-12-12, 6
days after the rule was added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants