-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ruff] Stabilize if-key-in-dict-del (RUF051)
#16658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary -- Stabilizes RUF051. The tests and docs looked good. Test Plan -- 1 closed documentation issue from 4 days after the rule was added and 1 typo fix from the same day it was added, but no other issues or PRs.
CodSpeed Performance ReportMerging #16658 will degrade performances by 10.81%Comparing Summary
Benchmarks breakdown
|
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF051 | 18 | 18 | 0 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
Contributor
Author
|
These all look like true positives. |
MichaReiser
approved these changes
Mar 12, 2025
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
Summary -- Stabilizes RUF051. The tests and docs looked good. Test Plan -- 1 closed documentation issue from 4 days after the rule was added and 1 typo fix from the same day it was added, but no other issues or PRs.
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
Summary -- Stabilizes RUF051. The tests and docs looked good. Test Plan -- 1 closed documentation issue from 4 days after the rule was added and 1 typo fix from the same day it was added, but no other issues or PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes RUF051. The tests and docs looked good.
Test Plan
1 closed documentation issue from 4 days after the rule was added and 1 typo fix from the same day it was added, but no other issues or PRs.