Skip to content

[red-knot] Minor optimization/cleanup in member lookup #16663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

[red-knot] Minor optimization/cleanup in member lookup #16663

merged 1 commit into from
Mar 12, 2025

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Mar 12, 2025

Summary

A follow up to address this comment:

Similarly here, it might be a little more performant to have a single Type::instance() branch with an inner match over class.known() rather than having multiple branches with if class.is_known() guards

@sharkdp sharkdp added the ty Multi-file analysis & type inference label Mar 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

mypy_primer results

No ecosystem changes detected ✅

@sharkdp sharkdp merged commit 3228545 into main Mar 12, 2025
22 checks passed
@sharkdp sharkdp deleted the david/member-lookup-optimization branch March 12, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@carljm carljm Awaiting requested review from carljm

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharkdp @MichaReiser