-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add missing unit tests for # noqa: A-like cases
#16677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #16677 will degrade performances by 10.49%Comparing Summary
Benchmarks breakdown
|
|
|
Thanks!
These cases are covered by this part of the spec:
e.g. |
## Summary Follow-up to #16677. This change converts all unit tests (69 of them) in `noqa.rs` to use inline snapshots instead. It extends the file by more than 1000 lines, but the tests are now much easier to read and reason about. ## Test Plan `cargo insta test`.
## Summary Follow-up to #16659. This change adds tests for these three cases, which are (also) not covered by existing tests: * `# noqa: A` (lone incomplete code) * `# noqa: A123, B` (complete codes, last one incomplete) * `# noqa: A123B` (squashed codes, last one incomplete)
## Summary Follow-up to #16677. This change converts all unit tests (69 of them) in `noqa.rs` to use inline snapshots instead. It extends the file by more than 1000 lines, but the tests are now much easier to read and reason about. ## Test Plan `cargo insta test`.
## Summary Follow-up to #16659. This change adds tests for these three cases, which are (also) not covered by existing tests: * `# noqa: A` (lone incomplete code) * `# noqa: A123, B` (complete codes, last one incomplete) * `# noqa: A123B` (squashed codes, last one incomplete)
## Summary Follow-up to #16677. This change converts all unit tests (69 of them) in `noqa.rs` to use inline snapshots instead. It extends the file by more than 1000 lines, but the tests are now much easier to read and reason about. ## Test Plan `cargo insta test`.
Summary
Follow-up to #16659.
This change adds tests for these three cases, which are (also) not covered by existing tests:
# noqa: A(lone incomplete code)# noqa: A123, B(complete codes, last one incomplete)# noqa: A123B(squashed codes, last one incomplete)The third case is mentioned in the specification, but neither of the other two are:
Test Plan
Unit tests.