[red-knot] Add 'Format document' to playground #17217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
playground
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager,
dhruvmanila and
sharkdp
as code owners
Contributor
|
MichaReiser
commented
Apr 5, 2025
MichaReiser
commented
Apr 5, 2025
| } | ||
|
|
||
| const formatted = this.props.current.workspace.format(fileHandle); | ||
| if (formatted !== model.getValue()) { |
Member
Author
There was a problem hiding this comment.
We could be more fancy and change format to return a vec of text edits. I don't think we need this just yet (also comes at the cost of requiring a diff library)
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
playground/knot/src/Editor/Editor.tsx:366
- In the provideDocumentFormattingEdits implementation, consider explicitly returning null (instead of implicitly returning undefined) when no file is selected, to ensure consistent return types as expected by the formatting provider.
if (this.props.current.files.selected == null) {
Contributor
|
MichaReiser
force-pushed
the
micha/playground-format
branch
6 times, most recently
from
0c57690 to
8b60e4b
Compare
charliermarsh
approved these changes
Apr 7, 2025
MichaReiser
force-pushed
the
micha/playground-format
branch
from
1f50f57 to
4999cc8
Compare
MichaReiser
force-pushed
the
micha/playground-format
branch
from
54149c1 to
a9f5d06
Compare
dcreager
added a commit
that referenced
this pull request
Apr 7, 2025
* main: (42 commits) [playground] New default program (#17277) [red-knot] Add `--python-platform` CLI option (#17284) [red-knot] Allow ellipsis default params in stub functions (#17243) [red-knot] Fix stale syntax errors in playground (#17280) Update Rust crate clap to v4.5.35 (#17273) Fix RUF100 to detect unused file-level noqa directives with specific codes (#17042) (#17061) [ci] Fix pattern for code changes (#17275) [`airflow`] Update oudated `AIR301`, `AIR302` rules (#17123) [docs] fix formatting of "See Style Guide" link (#17272) [red-knot] Support stub packages (#17204) ruff_annotate_snippets: address unused code warnings [red-knot] Add a couple more tests for `*` imports (#17270) [red-knot] Add 'Format document' to playground (#17217) Update actions/setup-node action to v4.3.0 (#17259) Update actions/upload-artifact action to v4.6.2 (#17261) Update actions/download-artifact action to v4.2.1 (#17258) Update actions/setup-python action to v5.5.0 (#17260) Update actions/cache action to v4.2.3 (#17256) Update Swatinem/rust-cache action to v2.7.8 (#17255) Update actions/checkout action to v4.2.2 (#17257) ...
dcreager
added a commit
that referenced
this pull request
Apr 8, 2025
* main: (222 commits) [playground] New default program (#17277) [red-knot] Add `--python-platform` CLI option (#17284) [red-knot] Allow ellipsis default params in stub functions (#17243) [red-knot] Fix stale syntax errors in playground (#17280) Update Rust crate clap to v4.5.35 (#17273) Fix RUF100 to detect unused file-level noqa directives with specific codes (#17042) (#17061) [ci] Fix pattern for code changes (#17275) [`airflow`] Update oudated `AIR301`, `AIR302` rules (#17123) [docs] fix formatting of "See Style Guide" link (#17272) [red-knot] Support stub packages (#17204) ruff_annotate_snippets: address unused code warnings [red-knot] Add a couple more tests for `*` imports (#17270) [red-knot] Add 'Format document' to playground (#17217) Update actions/setup-node action to v4.3.0 (#17259) Update actions/upload-artifact action to v4.6.2 (#17261) Update actions/download-artifact action to v4.2.1 (#17258) Update actions/setup-python action to v5.5.0 (#17260) Update actions/cache action to v4.2.3 (#17256) Update Swatinem/rust-cache action to v2.7.8 (#17255) Update actions/checkout action to v4.2.2 (#17257) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is more "because we can" than something we need.
But since we're already building an "almost IDE"
Test Plan
Screen.Recording.2025-04-05.at.10.12.38.mov