Sync vendored typeshed stubs #17402
Merged
Sync vendored typeshed stubs #17402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
AlexWaygood,
MichaReiser,
carljm and
sharkdp
as code owners
Contributor
Author
|
Contributor
|
The tests are failing because line numbers in typeshed have changed, and so we need to update some diagnostics snapshots that show code snippets from typeshed (referencing the function that was called). I guess we could look into ignoring linenumber-only changes automatically somehow via insta redactions, if it turns out to be annoying. Or we could auto-update snapshots in the typeshed CI workflow, but the we would need to carefully review the diffs (outside the vendored typeshed folder). |
Contributor
|
The ecosystem changes are somewhat obscure. We now emit fewer false positives on
I will merge this PR, as it is not the source of the problem. But I think that we need to change something here. We should probably drop support for 3.7 and 3.8? And maybe we should also change the |
Member
|
Apparently this typeshed update sped up the cold benchmark by 3%, and the micro benchmark by 2%: https://codspeed.io/astral-sh/ruff/branches/typeshedbot%2Fsync-typeshed. I guess that's because we create fewer visibility-constraint predicates in |
dcreager
added a commit
that referenced
this pull request
Apr 15, 2025
* main: (31 commits) [red-knot] Add some knowledge of `__all__` to `*`-import machinery (#17373) Update taiki-e/install-action digest to be7c31b (#17379) Update Rust crate mimalloc to v0.1.46 (#17382) Update PyO3/maturin-action action to v1.49.1 (#17384) Update Rust crate anyhow to v1.0.98 (#17380) dependencies: switch from `chrono` to `jiff` Update Rust crate bstr to v1.12.0 (#17385) [red-knot] Further optimize `*`-import visibility constraints (#17375) [red-knot] Minor 'member_lookup_with_policy' fix (#17407) [red-knot] Initial support for `dataclass`es (#17353) Sync vendored typeshed stubs (#17402) [red-knot] improve function/bound method type display (#17294) [red-knot] Move relation methods from `CallableType` to `Signature` (#17365) [syntax-errors] `await` outside async functions (#17363) [red-knot] optimize is_subtype_of for literals (#17394) [red-knot] add a large-union-of-string-literals benchmark (#17393) Update pre-commit dependencies (#17383) [red-knot] mypy_primer: Fail job on panic or internal errors (#17389) [red-knot] Document limitations of diagnostics-silencing in unreachable code (#17387) [red-knot] detect unreachable attribute assignments (#16852) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close and reopen this PR to trigger CI