[red-knot] Add regression tests for narrowing constraints cycles #17408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cake-monotone
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
AlexWaygood
added
testing
Contributor
|
Contributor
Author
sharkdp
pushed a commit
that referenced
this pull request
Apr 16, 2025
) ## Summary closes #17215 This PR adds regression tests for the following cycled queries: - all_narrowing_constraints_for_expression - all_negative_narrowing_constraints_for_expression The following test files are included: - `red_knot_project/resources/test/corpus/cycle_narrowing_constraints.py` - `red_knot_project/resources/test/corpus/cycle_negative_narrowing_constraints.py` These test names don't follow the existing naming convention based on Cinder. However, I’ve chosen these names to clearly reflect the regression cases. Let me know if you’d prefer to align more closely with the existing Cinder-based style. ## Test Plan ```sh git checkout 1a6a10b cargo test --package red_knot_project -- corpus ```
dcreager
added a commit
that referenced
this pull request
Apr 16, 2025
* main: (44 commits) [`airflow`] Extend `AIR311` rules (#17422) [red-knot] simplify union size limit handling (#17429) [`airflow`] Extract `AIR311` from `AIR301` rules (`AIR301`, `AIR311`) (#17310) [red-knot] set a size limit on unions of literals (#17419) [red-knot] make large-union benchmark slow again (#17418) [red-knot] optimize building large unions of literals (#17403) [red-knot] Fix comments in type_api.md (#17425) [red-knot] Do not assume that `x != 0` if `x` inhabits `~Literal[0]` (#17370) [red-knot] make large-union benchmark more challenging (#17416) [red-knot] Acknowledge that `T & anything` is assignable to `T` (#17413) Update Rust crate clap to v4.5.36 (#17381) Raise syntax error when `\` is at end of file (#17409) [red-knot] Add regression tests for narrowing constraints cycles (#17408) [red-knot] Add some knowledge of `__all__` to `*`-import machinery (#17373) Update taiki-e/install-action digest to be7c31b (#17379) Update Rust crate mimalloc to v0.1.46 (#17382) Update PyO3/maturin-action action to v1.49.1 (#17384) Update Rust crate anyhow to v1.0.98 (#17380) dependencies: switch from `chrono` to `jiff` Update Rust crate bstr to v1.12.0 (#17385) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #17215
This PR adds regression tests for the following cycled queries:
The following test files are included:
red_knot_project/resources/test/corpus/cycle_narrowing_constraints.pyred_knot_project/resources/test/corpus/cycle_negative_narrowing_constraints.pyThese test names don't follow the existing naming convention based on Cinder.
However, I’ve chosen these names to clearly reflect the regression cases.
Let me know if you’d prefer to align more closely with the existing Cinder-based style.
Test Plan
git checkout 1a6a10b30 cargo test --package red_knot_project -- corpus