Skip to content

[red-knot] Fix comments in type_api.md #17425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

[red-knot] Fix comments in type_api.md #17425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
603f219
Fix comments in type_api.md
MatthewMckee4 Apr 16, 2025
7ac8405
Delete playground/shared/package-lock.json
AlexWaygood Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/red_knot_python_semantic/resources/mdtest/type_api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ def negate(n1: Not[int], n2: Not[Not[int]], n3: Not[Not[Not[int]]]) -> None:
n: Not[int, str]

def static_truthiness(not_one: Not[Literal[1]]) -> None:
# these are both boolean-literal types,
# since all possible runtime objects that are created by the literal syntax `1`
# TODO: `bool` is not incorrect, but these would ideally be `Literal[True]` and `Literal[False]`
# respectively, since all possible runtime objects that are created by the literal syntax `1`
# are members of the type `Literal[1]`
reveal_type(not_one is not 1) # revealed: bool
reveal_type(not_one is 1) # revealed: bool
Expand Down