[red-knot] Simplify visibility constraint handling for *-import definitions
#17486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
AlexWaygood
force-pushed
the
alex/optimize-star-imports
branch
2 times, most recently
from
c760611 to
e662997
Compare
Member
Author
|
neutral on codspeed: https://codspeed.io/astral-sh/ruff/branches/alex%2Foptimize-star-imports |
dcreager
approved these changes
Apr 21, 2025
Member
dcreager
left a comment
dcreager
left a comment
There was a problem hiding this comment.
I doubt this provides a meaningful speedup in many cases, since it's just very uncommon to use a
*-import definition to override a pre-existing definition. I'm filing the PR anyway, however, as it ends up simplifying the code inbuilder.rsa fair bit. We no longer have to branch on whether the symbol is newly added or not; we can just do the same thing in both cases.
Simplified code with no performance regression counts as a win to me!
|
|
||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub(super) struct SymbolState { | ||
| pub(in crate::semantic_index) struct SymbolState { |
Member
There was a problem hiding this comment.
🤯 We do have pub(grandparent) as a possibility, I did not know that! I still worry that we might be over-thinking visibility within this crate, but that is not at all a blocker for this PR.
AlexWaygood
force-pushed
the
alex/optimize-star-imports
branch
from
29b64a2 to
53afc0a
Compare
dcreager
added a commit
that referenced
this pull request
Apr 21, 2025
* main: Update pre-commit dependencies (#17506) [red-knot] Simplify visibility constraint handling for `*`-import definitions (#17486) [red-knot] Detect (some) invalid protocols (#17488) [red-knot] Correctly identify protocol classes (#17487) Update dependency ruff to v0.11.6 (#17516) Update Rust crate shellexpand to v3.1.1 (#17512) Update Rust crate proc-macro2 to v1.0.95 (#17510) Update Rust crate rand to v0.9.1 (#17511) Update Rust crate libc to v0.2.172 (#17509) Update Rust crate jiff to v0.2.9 (#17508) Update Rust crate clap to v4.5.37 (#17507) Update astral-sh/setup-uv action to v5.4.2 (#17504) Update taiki-e/install-action digest to 09dc018 (#17503) [red-knot] infer attribute assignments bound in comprehensions (#17396) [red-knot] simplify gradually-equivalent types out of unions and intersections (#17467) [red-knot] pull primer projects to run from file (#17473)
dcreager
added a commit
that referenced
this pull request
Apr 22, 2025
* main: (37 commits) [red-knot] Add list of failing/slow ecosystem projects (#17474) [red-knot] mypy_primer: extend ecosystem checks (#17544) [red-knot] Move `InstanceType` to its own submodule (#17525) [red-knot] mypy_primer: capture backtraces (#17543) [red-knot] mypy_primer: Use upstream repo (#17500) [red-knot] `typing.dataclass_transform` (#17445) Update dependency react-resizable-panels to v2.1.8 (#17513) Update dependency smol-toml to v1.3.3 (#17505) Update dependency uuid to v11.1.0 (#17517) Update actions/setup-node action to v4.4.0 (#17514) [red-knot] Fix variable name (#17532) [red-knot] Add basic subtyping between class literal and callable (#17469) [`pyupgrade`] Add fix safety section to docs (`UP030`) (#17443) [`perflint`] Allow list function calls to be replaced with a comprehension (`PERF401`) (#17519) Update pre-commit dependencies (#17506) [red-knot] Simplify visibility constraint handling for `*`-import definitions (#17486) [red-knot] Detect (some) invalid protocols (#17488) [red-knot] Correctly identify protocol classes (#17487) Update dependency ruff to v0.11.6 (#17516) Update Rust crate shellexpand to v3.1.1 (#17512) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A bank-holiday-weekend refactoring PR 😆
I was curious about just how invasive the change would be if I took action on my comment in #17375 (comment) (optimising the slow path for
*imports as well as the fast path). It turns out, not very invasive at all! Only one new API has to be added to the use-def map, and it's a fairly innocuous API in my opinion.I doubt this provides a meaningful speedup in many cases, since it's just very uncommon to use a
*-import definition to override a pre-existing definition. I'm filing the PR anyway, however, as it ends up simplifying the code inbuilder.rsa fair bit. We no longer have to branch on whether the symbol is newly added or not; we can just do the same thing in both cases.Test Plan
cargo test -p red_knot_python_semantic