Skip to content

Conversation

@dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Apr 27, 2025

What it says on the tin 😄

@dylwil3 dylwil3 added parser Related to the parser python314 Related to Python 3.14 labels Apr 27, 2025
@dylwil3 dylwil3 mentioned this pull request Apr 27, 2025
1 task
@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dylwil3 dylwil3 force-pushed the unparenthesized-except branch from 172575b to a021554 Compare April 28, 2025 21:40
@dylwil3 dylwil3 marked this pull request as ready for review April 28, 2025 21:40
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to the PR itelf but related to the syntax change. We should decide if we want to change the formatter when targeting Python 3.14 to preserve parentheses, always remove them when they fit on a single line, or always add them (what it currently does)

@dylwil3 dylwil3 merged commit 3c460a7 into astral-sh:main Apr 29, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parser Related to the parser python314 Related to Python 3.14

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants