-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Make syntax error for unparenthesized except tuples version specific to before 3.14 #17660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
172575b to
a021554
Compare
dhruvmanila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
MichaReiser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to the PR itelf but related to the syntax change. We should decide if we want to change the formatter when targeting Python 3.14 to preserve parentheses, always remove them when they fit on a single line, or always add them (what it currently does)
What it says on the tin 😄