Skip S608 for expressionless f-strings #17999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #17967
Summary
Skip
S608for expressionless f-strings.Expressionless f-strings are not vulnerable to SQL injections and F541 catches expressionless f-strings with an autofix.
This is achieved with guarding on the
S608f-string match with an occurrence check for expressions within it; analogous to the implementation of F451.Test Plan
Added a test fixture and updated snapshot.