[ty] Assume type of self is typing.Self in method calls
#18007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glyphack
force-pushed
the
typing-self-argument
branch
from
9e2b11b to
419d085
Compare
Glyphack
force-pushed
the
typing-self-argument
branch
from
775f97d to
d213dcc
Compare
Glyphack
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Contributor
Author
|
I'm un drafting to get some suggestions. Then I'll be quick in adjusting the PR. |
Glyphack
force-pushed
the
typing-self-argument
branch
3 times, most recently
from
58e61b4 to
95518f5
Compare
Glyphack
commented
May 16, 2025
| ); | ||
| return Ok(Type::unknown()); | ||
| }; | ||
| let class_ty = infer_definition_types(db, class_def) |
Contributor
Author
There was a problem hiding this comment.
From an older comment on the typing.Self PR.
Glyphack
force-pushed
the
typing-self-argument
branch
from
95518f5 to
c3c935b
Compare
Glyphack
force-pushed
the
typing-self-argument
branch
from
c3c935b to
c795732
Compare
Contributor
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Glyphack
force-pushed
the
typing-self-argument
branch
5 times, most recently
from
9a697f6 to
63531ea
Compare
MichaReiser
changed the title
typing.Selftyping.Self
Glyphack
changed the title
typing.Selftyping.Self in method calls
4 tasks
Glyphack
force-pushed
the
typing-self-argument
branch
2 times, most recently
from
6f8a2b4 to
178f48f
Compare
Co-Authored-by: David Peter <mail@david-peter.de>
sharkdp
force-pushed
the
typing-self-argument
branch
from
c7dcdcc to
ed798a3
Compare
sharkdp
reviewed
Sep 15, 2025
| reveal_type(x) # revealed: list[A | str] | ||
| for item in x: | ||
| reveal_type(item) # revealed: list[A | str] | str | ||
| reveal_type(item) # revealed: list[Any | str] | str |
Contributor
There was a problem hiding this comment.
This regression is tracked in astral-sh/ty#1157
This was referenced Sep 17, 2025
Contributor
|
I am planning to make a couple of additional changes here, and I'm also going to merge in other branches. So I'm going to merge this PR into a new integration branch (#20517). That also makes it a bit easier for me to run |
sharkdp
merged commit 92e01d5
into
astral-sh:david/implicit-self-signature
36 of 38 checks passed
sharkdp
added a commit
that referenced
this pull request
Sep 23, 2025
…#20479) ### Summary This PR includes two changes, both of which are necessary to resolve astral-sh/ty#1196: * For a generic class `C[T]`, we previously used `C[Unknown]` as the upper bound of the `Self` type variable. There were two problems with this. For one, when `Self` appeared in contravariant position, we would materialize its upper bound to `Bottom[C[Unknown]]` (which might simplify to `C[Never]` if `C` is covariant in `T`) when accessing methods on `Top[C[Unknown]]`. This would result in `invalid-argument` errors on the `self` parameter. Also, using an upper bound of `C[Unknown]` would mean that inside methods, references to `T` would be treated as `Unknown`. This could lead to false negatives. To fix this, we now use `C[T]` (with a "nested" typevar) as the upper bound for `Self` on `C[T]`. * In order to make this work, we needed to allow assignability/subtyping of inferable typevars to other types, since we now check assignability of e.g. `C[int]` to `C[T]` (when checking assignability to the upper bound of `Self`) when calling an instance-method on `C[int]` whose `self` parameter is annotated as `self: Self` (or implicitly `Self`, following #18007). closes astral-sh/ty#1196 closes astral-sh/ty#1208 ### Test Plan Regression tests for both issues.
sharkdp
added a commit
that referenced
this pull request
Sep 23, 2025
Part of astral-sh/ty#159 This PR only adjusts the signature of a method so if it has a `self` argument then that argument will have type of `Typing.Self` even if it's not specified. If user provides an explicit annotation then Ty will not override that annotation. - astral-sh/ty#1131 - astral-sh/ty#1157 - astral-sh/ty#1156 - astral-sh/ty#1173 - #20328 - astral-sh/ty#1163 - astral-sh/ty#1196 Added mdtests. Also some tests need #18473 to work completely. So I added a todo for those new cases that I added. --------- Co-authored-by: David Peter <mail@david-peter.de>
sharkdp
added a commit
that referenced
this pull request
Sep 24, 2025
Part of astral-sh/ty#159 This PR only adjusts the signature of a method so if it has a `self` argument then that argument will have type of `Typing.Self` even if it's not specified. If user provides an explicit annotation then Ty will not override that annotation. - astral-sh/ty#1131 - astral-sh/ty#1157 - astral-sh/ty#1156 - astral-sh/ty#1173 - #20328 - astral-sh/ty#1163 - astral-sh/ty#1196 Added mdtests. Also some tests need #18473 to work completely. So I added a todo for those new cases that I added. --------- Co-authored-by: David Peter <mail@david-peter.de>
sharkdp
added a commit
that referenced
this pull request
Sep 25, 2025
Part of astral-sh/ty#159 This PR only adjusts the signature of a method so if it has a `self` argument then that argument will have type of `Typing.Self` even if it's not specified. If user provides an explicit annotation then Ty will not override that annotation. - astral-sh/ty#1131 - astral-sh/ty#1157 - astral-sh/ty#1156 - astral-sh/ty#1173 - #20328 - astral-sh/ty#1163 - astral-sh/ty#1196 Added mdtests. Also some tests need #18473 to work completely. So I added a todo for those new cases that I added. --------- Co-authored-by: David Peter <mail@david-peter.de>
sharkdp
added a commit
that referenced
this pull request
Sep 25, 2025
Part of astral-sh/ty#159 This PR only adjusts the signature of a method so if it has a `self` argument then that argument will have type of `Typing.Self` even if it's not specified. If user provides an explicit annotation then Ty will not override that annotation. - astral-sh/ty#1131 - astral-sh/ty#1157 - astral-sh/ty#1156 - astral-sh/ty#1173 - #20328 - astral-sh/ty#1163 - astral-sh/ty#1196 Added mdtests. Also some tests need #18473 to work completely. So I added a todo for those new cases that I added. --------- Co-authored-by: David Peter <mail@david-peter.de>
sharkdp
added a commit
that referenced
this pull request
Sep 29, 2025
Part of astral-sh/ty#159 This PR only adjusts the signature of a method so if it has a `self` argument then that argument will have type of `Typing.Self` even if it's not specified. If user provides an explicit annotation then Ty will not override that annotation. - astral-sh/ty#1131 - astral-sh/ty#1157 - astral-sh/ty#1156 - astral-sh/ty#1173 - #20328 - astral-sh/ty#1163 - astral-sh/ty#1196 Added mdtests. Also some tests need #18473 to work completely. So I added a todo for those new cases that I added. --------- Co-authored-by: David Peter <mail@david-peter.de>
sharkdp
added a commit
that referenced
this pull request
Sep 29, 2025
Part of astral-sh/ty#159 This PR only adjusts the signature of a method so if it has a `self` argument then that argument will have type of `Typing.Self` even if it's not specified. If user provides an explicit annotation then Ty will not override that annotation. - astral-sh/ty#1131 - astral-sh/ty#1157 - astral-sh/ty#1156 - astral-sh/ty#1173 - #20328 - astral-sh/ty#1163 - astral-sh/ty#1196 Added mdtests. Also some tests need #18473 to work completely. So I added a todo for those new cases that I added. --------- Co-authored-by: David Peter <mail@david-peter.de>
sharkdp
added a commit
that referenced
this pull request
Sep 29, 2025
Part of astral-sh/ty#159 This PR only adjusts the signature of a method so if it has a `self` argument then that argument will have type of `Typing.Self` even if it's not specified. If user provides an explicit annotation then Ty will not override that annotation. - astral-sh/ty#1131 - astral-sh/ty#1157 - astral-sh/ty#1156 - astral-sh/ty#1173 - #20328 - astral-sh/ty#1163 - astral-sh/ty#1196 Added mdtests. Also some tests need #18473 to work completely. So I added a todo for those new cases that I added. --------- Co-authored-by: David Peter <mail@david-peter.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of astral-sh/ty#159
This PR only adjusts the signature of a method so if it has a
selfargument then that argument will have type ofTyping.Selfeven if it's not specified. If user provides an explicit annotation then Ty will not override that annotation.Follow Ups
selfargument when a generic context exists ty#1131Anyin return types of generic methods ty#1157Selffor fallback-methods onNamedTuples andTypedDicts #20328Top[list[Unknown]]does not satisfy upper boundBottom[MutableSequence[Unknown]]of type variableSelfty#1196Test Plan
Added mdtests.
Also some tests need #18473 to work completely. So I added a todo for those new cases that I added.