Skip to content

[flake8-pie] Mark autofix for PIE804 as unsafe if the dictionary contains comments #18046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

[flake8-pie] Mark autofix for PIE804 as unsafe if the dictionary contains comments #18046

merged 2 commits into from
May 12, 2025

Conversation

@LaBatata101
Copy link
Contributor

@LaBatata101 LaBatata101 commented May 12, 2025

Summary

Fixes #18036

Test Plan

Update existing snapshot tests.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dylwil3 dylwil3 added bug Something isn't working fixes Related to suggested fixes for violations labels May 12, 2025
dylwil3
dylwil3 approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@dylwil3 dylwil3 merged commit 6b3ff6f into astral-sh:main May 12, 2025
34 checks passed
@LaBatata101 LaBatata101 deleted the fix-PIE804 branch May 12, 2025 19:29
dcreager added a commit that referenced this pull request May 12, 2025
@dcreager
Merge branch 'main' into dcreager/specialize-deepish
7408d0c 
* main:
  [ty] Apply function specialization to all overloads (#18020)
  Add comma to panic message (#18048)
  [`flake8-pie`] Mark autofix for `PIE804` as unsafe if the dictionary contains comments (#18046)
  [ty] fix infinite recursion bug in `is_disjoint_from` (#18043)
@BrewTestBot BrewTestBot mentioned this pull request May 15, 2025
Merged
Glyphack pushed a commit to Glyphack/ruff that referenced this pull request May 21, 2025
@LaBatata101 @Glyphack
[flake8-pie] Mark autofix for PIE804 as unsafe if the dictionary …
80ca21e 
…contains comments (astral-sh#18046)

## Summary

Fixes astral-sh#18036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylwil3 dylwil3 dylwil3 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working fixes Related to suggested fixes for violations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PIE804 autofix is destructive

2 participants

@LaBatata101 @dylwil3