[flake8-simplify] add fix safety section (SIM210)
#18100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ntBre
reviewed
May 14, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I think this time we do need a note about comments.
| /// return a proper Boolean. While the fix will try to wrap non-boolean values in a call to bool, | ||
| /// custom implementations of comparison functions like `__eq__` can avoid the bool call and still | ||
| /// lead to altered behavior. | ||
| /// |
Contributor
There was a problem hiding this comment.
This one actually does drop comments 😆 : https://play.ruff.rs/a415e7a8-c951-4ed8-af98-a0ebcbc41a40
but only in the case of multi-line if-expressions, which were easiest for me to cause with implicitly-concatenated strings, so it might be pretty rare.
Contributor
Author
There was a problem hiding this comment.
I will update ;)
I admit that I was lazy and i didn't check
Contributor
Author
Added ;-) |
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
The PR add the `fix safety` section for rule `SIM210` (astral-sh#15584 ) It is a little cheating, as the Fix safety section is copy/pasted by astral-sh#18086 as the problem is the same. ### Unsafe Fix Example ```python class Foo(): def __eq__(self, other): return 0 def foo(): return True if Foo() == 0 else False def foo_fix(): return Foo() == 0 print(foo()) # False print(foo_fix()) # 0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add the
fix safetysection for ruleSIM210(#15584 )It is a little cheating, as the Fix safety section is copy/pasted by #18086 as the problem is the same.
Unsafe Fix Example