Skip to content

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented May 19, 2025

Summary

Pulls in hauntsaninja/mypy_primer#171 which configures psycopg's src root

Thanks @sharkdp for making the change upstream

Test Plan

CI

@MichaReiser MichaReiser added the ci Related to internal CI tooling label May 19, 2025
@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅

@MichaReiser
Copy link
Member Author

MichaReiser commented May 19, 2025

It's disappointing that we don't see any mypy primer changs but makes sense, given that it mainly tests the binary.

Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand how it's possible that we see no primer diff here, if the mypy-primer change is working correctly, since my understanding is we previously weren't really checking any of the psycopg source code?

But this certainly doesn't seem to do any harm!

@AlexWaygood
Copy link
Member

AlexWaygood commented May 19, 2025

Not sure I understand how it's possible that we see no primer diff here, if the mypy-primer change is working correctly, since my understanding is we previously weren't really checking any of the psycopg source code?

It's because we're running the same version of primer on this commit and the commit prior to this commit and then diffing the two sets of diagnostics. Since the same version of primer is being run on both commits, the same psycopg config is being used for both primer runs.

@MichaReiser MichaReiser merged commit 59d80af into main May 19, 2025
35 checks passed
@MichaReiser MichaReiser deleted the micha/upgrade-mypy-primer branch May 19, 2025 15:35
dcreager added a commit that referenced this pull request May 19, 2025
* main:
  [ty] Infer function call typevars in both directions (#18155)
  Add rustfmt.toml file (#18197)
  [ty] Update mypy primer (#18196)
  [ty] Mark generated files as such in .gitattributes (#18195)
  [ty] Support `typing.TypeAliasType` (#18156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to internal CI tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants