[ty] Use first matching constructor overload when inferring specializations #18204
+20
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcreager
commented
May 19, 2025
Comment on lines
363
to
364
| # TODO: revealed: C[bytes] | ||
| reveal_type(C(b"bytes")) # revealed: C[bytes | int] |
Member
Author
There was a problem hiding this comment.
Without the code changes, this test mimics the TemporaryDirectory behavior, returning a union specialization
Contributor
|
dhruvmanila
approved these changes
May 19, 2025
Comment on lines
-4669
to
+4659
| .and_then(|binding| combine_binding_specialization(db, binding)) | ||
| .into_iter() | ||
| .flat_map(CallableBinding::matching_overloads) | ||
| .next() | ||
| .and_then(|(_, binding)| binding.inherited_specialization()) |
Member
There was a problem hiding this comment.
I think this is my mistake as I didn't revert this part from #17618 and only reverted the intersection of return type, sorry! 🙈
dcreager
added a commit
that referenced
this pull request
May 19, 2025
* main: [ty] Use first matching constructor overload when inferring specializations (#18204) [ty] Add hint that PEP 604 union syntax is only available in 3.10+ (#18192) Unify `Message` variants (#18051) [`airflow`] Update `AIR301` and `AIR311` with the latest Airflow implementations (#17985) [`airflow`] Move rules from `AIR312` to `AIR302` (#17940) [ty] Small LSP cleanups (#18201) [ty] Show related information in diagnostic (#17359) Default `src.root` to `['.', '<project_name>']` if the directory exists (#18141)
carljm
reviewed
May 19, 2025
| @overload | ||
| def __init__(self: "C[bytes]", x: bytes) -> None: ... | ||
| @overload | ||
| def __init__(self: "C[int]", x: bytes) -> None: ... |
Contributor
There was a problem hiding this comment.
Maybe not worth a separate follow-up PR, but wouldn't we ideally have a case where the second argument is optional and so we can have multiple matching overloads, and show that we pick the first?
Member
Author
There was a problem hiding this comment.
This gives us two matching overloads if you provide a bytes parameter, and we show that we pick the first (giving C[bytes] instead of C[int] or C[bytes | int]). Maybe deserves a comment, since the argument / specialization pattern across the overloads is subtle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #18155. For the example raised in astral-sh/ty#370:
the new logic would notice that both overloads of
TemporaryDirectorymatch, and combine their specializations, resulting in an inferred type ofstr | bytes.This PR updates the logic to match our other handling of other calls, where we only keep the first matching overload. The result for this example then becomes
str, matching the runtime behavior. (We still do not implement the full overload resolution algorithm from the spec.)