[ty] Add note to unresolved-import hinting to users to configure their Python environment
#18207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyBZhang
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
EmilyBZhang
force-pushed
the
emily/unresolved-import-python-env-note
branch
from
50fadda to
6bfbf47
Compare
AlexWaygood
approved these changes
May 19, 2025
Contributor
|
dcreager
approved these changes
May 19, 2025
Member
dcreager
left a comment
dcreager
left a comment
There was a problem hiding this comment.
This looks great, thank you!
I'm okay with the link to the GitHub repo readme — we will want to update that to a more stable URL in the future once we have the docs hosted in a more stable place. But I don't think that needs to block this, since we'll want to do a careful vet of links when we do that anyway!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes astral-sh/ty#453.
Summary
Add an additional info diagnostic to
unresolved-importcheck to hint to users that they should make sure their Python environment is properly configured for ty, linking them to the corresponding doc. This diagnostic is only shown when an import is not relative, e.g.,import maturinnotimport .maturin.Test Plan
Updated snapshots with new info message and reran tests.