[ty] Deeply normalize many types #18222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Member
Author
|
1% speedup on the many_string_assignments benchmark! No idea why, but I'll take it 😄 https://codspeed.io/astral-sh/ruff/branches/alex%2Fdeeply-normalize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies deep normalization to many type variants that wrap other types. This should mean that we have more robust handling for equivalence and gradual equivalence even when encountering differently ordered unions.
I went down this road because I was hoping it would solve astral-sh/ty#459. It doesn't look like it does (at least not on its own), but it seems like something that should make us more robust in the long term anyway.
Test Plan
cargo test -p ty_python_semantic