[ty] Simplify signature types, use them in CallableType
#18344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @dhruvmanila re the |
Contributor
|
dcreager
commented
May 27, 2025
Member
Author
There was a problem hiding this comment.
The diff of this file is less chatty if you hide whitespace
dhruvmanila
approved these changes
May 28, 2025
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Nice! This looks reasonable to me 👍
| } | ||
|
|
||
| /// Returns the call signatures of a type. | ||
| /// Returns an empty [`Bindings`] that can be used to analyze a call to this type. |
Member
There was a problem hiding this comment.
nit: It might be useful to provide a brief description on what "an empty Bindings" mean here as I don't think it's about an empty Bindings::elements but more about the fact that this is kind of an "initial" state before matching any parameters to the arguments and doing type checking.
Member
Author
There was a problem hiding this comment.
Done! By "empty" I meant that you have to do more work to actually analyze a call site using the Bindings you get back. I reworded the comment and added some more detail to explain that better.
* main: [ty] Support ephemeral uv virtual environments (#18335) Add a `ViolationMetadata::rule` method (#18234) Return `DiagnosticGuard` from `Checker::report_diagnostic` (#18232) [flake8_use_pathlib]: Replace os.symlink with Path.symlink_to (PTH211) (#18337) [ty] Support cancellation and retry in the server (#18273) [ty] Synthetic function-like callables (#18242) [ty] Support publishing diagnostics in the server (#18309) Add Autofix for ISC003 (#18256) [`pyupgrade`]: new rule UP050 (`useless-class-metaclass-type`) (#18334) [pycodestyle] Make `E712` suggestion not assume a context (#18328)
carljm
added a commit
to MatthewMckee4/ruff
that referenced
this pull request
May 28, 2025
* main: (246 commits) [ty] Simplify signature types, use them in `CallableType` (astral-sh#18344) [ty] Support ephemeral uv virtual environments (astral-sh#18335) Add a `ViolationMetadata::rule` method (astral-sh#18234) Return `DiagnosticGuard` from `Checker::report_diagnostic` (astral-sh#18232) [flake8_use_pathlib]: Replace os.symlink with Path.symlink_to (PTH211) (astral-sh#18337) [ty] Support cancellation and retry in the server (astral-sh#18273) [ty] Synthetic function-like callables (astral-sh#18242) [ty] Support publishing diagnostics in the server (astral-sh#18309) Add Autofix for ISC003 (astral-sh#18256) [`pyupgrade`]: new rule UP050 (`useless-class-metaclass-type`) (astral-sh#18334) [pycodestyle] Make `E712` suggestion not assume a context (astral-sh#18328) put similar dunder-call tests next to each other (astral-sh#18343) [ty] Derive `PartialOrd, Ord` for `KnownInstanceType` (astral-sh#18340) [ty] Simplify `Type::try_bool()` (astral-sh#18342) [ty] Simplify `Type::normalized` slightly (astral-sh#18339) [ty] Move arviz off the list of selected primer projects (astral-sh#18336) [ty] Add --config-file CLI arg (astral-sh#18083) [ty] Tell the user why we inferred a certain Python version when reporting version-specific syntax errors (astral-sh#18295) [ty] Implement implicit inheritance from `Generic[]` for PEP-695 generic classes (astral-sh#18283) [ty] Add hint if async context manager is used in non-async with statement (astral-sh#18299) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were many fields in
Signatureand friends that really had more to do with how a signature was being used — how it was looked up, details about an individual call site, etc. Those fields more properly belong inBindingsand friends.This is a pure refactoring, and should not affect any tests or ecosystem projects.
I started on this journey in support of astral-sh/ty#462. It seemed worth pulling out as a separate PR.
One major concrete benefit of this refactoring is that we can now use
CallableSignaturedirectly inCallableType. (We can't useCallableSignaturedirectly in thatTypevariant because signatures are not currently interned.)