[pygrep_hooks] Add AsyncMock methods to invalid-mock-access (PGH005)
#18547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
commented
Jun 8, 2025
| | "called_with" | ||
| | "has_calls" | ||
| | "not_called" | ||
| | "awaited" |
Contributor
Author
There was a problem hiding this comment.
N.B., the sync equivalent called is not in this list. That is because (sync) Mocks have a boolean attribute called. However, AsyncMocks do not have an attribute awaited. Therefore, assert mock.awaited is likely a mistake and was meant to be mock.assert_awaited().
robsdedude
commented
Jun 8, 2025
Contributor
|
ntBre
approved these changes
Jun 18, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Makes sense, thanks! Just one tiny suggestion to include the URL for the PR on the preview function.
Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>
ntBre
approved these changes
Jun 24, 2025
ntBre
changed the title
pygrep_hooks] add AsyncMock methods to invalid-mock-access (PGH005)pygrep_hooks] Add AsyncMock methods to invalid-mock-access (PGH005)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands PGH005 to also check for AsyncMock methods in the same vein. E.g., currently
assert mock.not_calledis linted. This PR adds the corresponding async assertionsassert mock.not_awaited().