Skip to content

Unify helpers modules #18835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2025
Merged

Unify helpers modules #18835

merged 3 commits into from
Jun 20, 2025

Conversation

@dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Jun 20, 2025 •
edited
Loading

A little bit of cleanup for consistency's sake: we move all the helpers modules to a consistent location, and update the import paths when needed. In the case of refurb there were two helpers modules, so we just merged them.

Happy to revert the last commit if people are okay with super::super I just thought it looked a little silly.

@dylwil3 dylwil3 requested a review from ntBre June 20, 2025 20:46
@dylwil3 dylwil3 added the internal An internal refactor or improvement label Jun 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

ntBre
ntBre approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I do prefer the crate imports over super::super too.

@dylwil3 dylwil3 merged commit 2d224e6 into astral-sh:main Jun 20, 2025
36 checks passed
@dylwil3 dylwil3 deleted the unify-helpers branch June 20, 2025 21:03
dcreager added a commit that referenced this pull request Jun 20, 2025
@dcreager
Merge branch 'main' into dcreager/tuple-spec
e5aa429 
* main:
  Handle parenthesized arguments in `remove_argument` (#18805)
  Unify helpers modules (#18835)
  Normalize some docs sections (#18831)
  [`flake8_pyi`] Fix `PYI041`'s fix causing TypeError with `None | None | ...` (#18637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntBre ntBre ntBre approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylwil3 @ntBre