-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update Salsa #19020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Salsa #19020
Conversation
ec358e3 to
fb0f860
Compare
|
@ibraheemdev can you take over this PR. It seems something broke the heap size feature upstream (maybe salsa-rs/salsa#927?) Edit: I pinned the commit to before said commit for now but that also means that the papaya commit is missing too. We should add a test in upstream salsa that catches the regression and fix it before merging this PR |
fb0f860 to
d609605
Compare
|
CodSpeed Instrumentation Performance ReportMerging #19020 will degrade performances by 7.34%Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #19020 will improve performances by ×8.5Comparing Summary
Benchmarks breakdown
|
|
|
Hmm, the memory usage changes here must be noise? |
d609605 to
baee7c3
Compare
Summary
This PR updates Salsa to pull in Ibraheems multithreading improvements
salsa-rs/salsa#921
Performance
A small regression for single-threaded benchmarks is expected because papaya is slightly slower than a
Mutex<FxHashMap>in the uncontested case (~10%). However, this shouldn't matter as much in practice because:Test Plan
cargo test