Fix F701 to F707 errors in tests #19125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
dylwil3
approved these changes
Jul 4, 2025
Collaborator
dylwil3
left a comment
dylwil3
left a comment
There was a problem hiding this comment.
thank you and good catch on B031!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per @ntBre in #19111, it would be a good idea to make the tests no longer have these syntax errors, so this PR updates the tests and snapshots.
B031gave me a lot of trouble since the ending test of declaring a function namedgroupbymakes it so that inside other functions, it's unclear whichgroupbyis referred to since it depends on when the function is called. To fix it I made each function have it's ownfrom itertools import groupbyso there's no more ambiguity.Test Plan
Updated tests and snapshots.