Skip to content

[refurb] Make example error out-of-the-box (FURB177) #19309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

[refurb] Make example error out-of-the-box (FURB177) #19309

merged 2 commits into from
Jul 14, 2025

Conversation

@close2code-palm
Copy link
Contributor

@close2code-palm close2code-palm commented Jul 13, 2025

Summary

Part of #18972
This PR makes implicit-cwd(FURB177)'s example error out-of-the-box.

Old example

cwd = Path().resolve()

New example

from pathlib import Path

cwd = Path().resolve()

Test Plan

N/A, no functionality/tests affected

@close2code-palm close2code-palm marked this pull request as ready for review July 13, 2025 14:53
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MeGaGiGaGon MeGaGiGaGon mentioned this pull request Jul 12, 2025
Open
@close2code-palm close2code-palm changed the title [refurb] Make FURB177 example error out-of-the-box [refurb] Make example error out-of-the-box (FURB177) Jul 13, 2025
@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Jul 14, 2025
dylwil3
dylwil3 approved these changes Jul 14, 2025
View reviewed changes
Copy link
Collaborator

@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dylwil3 dylwil3 merged commit a4562ac into astral-sh:main Jul 14, 2025
36 checks passed
dcreager added a commit that referenced this pull request Jul 14, 2025
@dcreager
Merge branch 'dcreager/merge-arguments' into dcreager/splat
dec9b73 
* dcreager/merge-arguments: (223 commits)
  fix docs
  Combine CallArguments and CallArgumentTypes
  [ty] Sync vendored typeshed stubs (#19334)
  [`refurb`] Make example error out-of-the-box (`FURB122`) (#19297)
  [refurb] Make example error out-of-the-box (FURB177) (#19309)
  [ty] ignore errors when reformatting codemodded typeshed (#19332)
  [ty] Provide docstrings for stdlib APIs when hovering over them in an IDE (#19311)
  [ty] Add virtual files to the only project database (#19322)
  Add t-string fixtures for rules that do not need to be modified (#19146)
  [ty] Remove `FileLookupError` (#19323)
  [ty] Fix handling of metaclasses in `object.<CURSOR>` completions
  [ty] Use an interval map for scopes by expression (#19025)
  [ty] List all `enum` members (#19283)
  [ty] Handle configuration errors in LSP more gracefully (#19262)
  [ty] Use python version and path from Python extension (#19012)
  [`pep8_naming`] Avoid false positives on standard library functions with uppercase names (`N802`) (#18907)
  Update Rust crate toml to 0.9.0 (#19320)
  [ty] Fix server version (#19284)
  Update NPM Development dependencies (#19319)
  Update taiki-e/install-action action to v2.56.13 (#19317)
  ...
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylwil3 dylwil3 dylwil3 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@close2code-palm @dylwil3 @MichaReiser