Canonicalize path before filtering #19407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
approved these changes
Jul 17, 2025
Contributor
Author
|
Yeah this is basically what I was afraid of with Windows. I'll try just including both filters and then bust out the Windows VM too if I have to. |
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This came up on Discord and also in #19387, but on macOS the tmp directory is a symlink to
/private/tmp, which breaks this filter. I'm still not quite sure why only these tests are affected when we use thetempdir_filterelsewhere, but hopefully this fixes the immediate issue. Justtempdir.path().canonicalize()also worked, but I usedduncesince that's what I saw in other tests (I guess it's not just these tests).Some related links from uv:
Thanks to @zanieb for those!
Test Plan
I tested the
mainbranch on my MacBook and reproduced the test failure, then confirmed that the tests pass after the change. Now to make sure it passes on Windows, which caused most of the trouble in the first PR!