[ty] Avoid secondary tree traversal to get call expression for keyword arguments #19429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
added
internal
Contributor
|
MichaReiser
force-pushed
the
micha/call-expr-goto-target
branch
from
fdfc2ee to
e1b7ac5
Compare
UnboundVariable
approved these changes
Jul 19, 2025
Collaborator
UnboundVariable
left a comment
UnboundVariable
left a comment
There was a problem hiding this comment.
Thanks, I misunderstood the feedback from your previous code review. This looks fine to me.
Member
Author
I'm sorry that my comment was unclear. |
UnboundVariable
pushed a commit
to UnboundVariable/ruff
that referenced
this pull request
Jul 19, 2025
* main: [ty] Avoid secondary tree traversal to get call expression for keyword arguments (astral-sh#19429) [ty] Add goto definition to playground (astral-sh#19425) [ty] Add support for `@warnings.deprecated` (astral-sh#19376) [ty] make `del x` force local resolution of `x` in the current scope (astral-sh#19389) # Conflicts: # crates/ty_ide/src/goto.rs
dcreager
added a commit
that referenced
this pull request
Jul 21, 2025
* main: (25 commits) [ty] Sync vendored typeshed stubs (#19461) [ty] Extend tuple `__len__` and `__bool__` special casing to also cover tuple subclasses (#19289) [ty] bump docstring-adder pin (#19458) [ty] Disallow assignment to `Final` class attributes (#19457) Update dependency ruff to v0.12.4 (#19442) Update pre-commit hook astral-sh/ruff-pre-commit to v0.12.4 (#19443) Update rui314/setup-mold digest to 702b190 (#19441) Update taiki-e/install-action action to v2.56.19 (#19448) Update Rust crate strum_macros to v0.27.2 (#19447) Update Rust crate strum to v0.27.2 (#19446) Update Rust crate rand to v0.9.2 (#19444) Update Rust crate serde_json to v1.0.141 (#19445) Fix `unreachable` panic in parser (#19183) [`ruff`] Support byte strings (`RUF055`) (#18926) [ty] Avoid second lookup for `infer_maybe_standalone_expression` (#19439) [ty] Implemented "go to definition" support for import statements (#19428) [ty] Avoid secondary tree traversal to get call expression for keyword arguments (#19429) [ty] Add goto definition to playground (#19425) [ty] Add support for `@warnings.deprecated` (#19376) [ty] make `del x` force local resolution of `x` in the current scope (#19389) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to https://github.com/astral-sh/ruff/pull/19417/files#r2215520292
Extract the enclosing
CallExprwhen resolving theKeywordArgumentgoto target (where we have access to the ancestor chain)instead of doing another tree traversal.
Not only is this faster. It's also less confusing (I assumed that there was more to it then just picking the parent call expression because it did use a second traversal).
Test Plan
cargo test