Skip to content

Conversation

@MichaReiser
Copy link
Member

Summary

Test Plan

@MichaReiser MichaReiser added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Jul 20, 2025
@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 20, 2025

CodSpeed WallTime Performance Report

Merging #19436 will degrade performances by 10.55%

Comparing micha/remove-infer-expression-query (8674cf3) with main (0acc273)

Summary

❌ 1 regressions
✅ 6 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
large[sympy] 42.6 s 47.6 s -10.55%

@MichaReiser
Copy link
Member Author

I'm a bit confused why this didn't change memory usage at all, given that it should have removed an entire query 😕

@AlexWaygood
Copy link
Member

AlexWaygood commented Jul 20, 2025

I'm a bit confused why this didn't change memory usage at all, given that it should have removed an entire query 😕

We only diff memory usage on four projects currently: https://github.com/astral-sh/ruff/blob/main/crates/ty_python_semantic/resources/primer/memory.txt. It might be worth expanding that list (if it means that the memory-diff job takes longer, we could consider having the memory usage reported in a separate comment so that we still get quick feedback on the diagnostics diff of a PR). I think sympy would be a very interesting one to add to the list, since it's a larger project that we have quite high memory usage on IIRC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants