Skip to content

Conversation

@ibraheemdev
Copy link
Member

Summary

Pulls in a bunch of salsa micro-optimizations.

@ibraheemdev ibraheemdev added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Jul 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed Instrumentation Performance Report

Merging #19449 will improve performances by 5.07%

Comparing ibraheem/update-salsa (d9b1a64) with main (7b4103b)

Summary

⚡ 1 improvements
✅ 41 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
ty_check_file[incremental] 5 ms 4.7 ms +5.07%

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed WallTime Performance Report

Merging #19449 will improve performances by 7.78%

Comparing ibraheem/update-salsa (d9b1a64) with main (7b4103b)

Summary

⚡ 7 improvements

Benchmarks breakdown

Benchmark BASE HEAD Change
large[sympy] 43.3 s 39.7 s +8.98%
medium[colour-science] 7.5 s 6.9 s +9.3%
medium[pandas] 28.6 s 26.3 s +8.57%
small[altair] 2.4 s 2.2 s +8.85%
small[freqtrade] 4.1 s 3.8 s +8%
small[pydantic] 2.3 s 2.1 s +9.57%
small[tanjun] 1.7 s 1.6 s +7.78%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@ibraheemdev ibraheemdev force-pushed the ibraheem/update-salsa branch from 5025ae4 to e7ee259 Compare July 21, 2025 04:51
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@ibraheemdev ibraheemdev force-pushed the ibraheem/update-salsa branch from e7ee259 to a3ac6f7 Compare July 21, 2025 15:40
@ibraheemdev ibraheemdev force-pushed the ibraheem/update-salsa branch from a3ac6f7 to 206a58f Compare July 30, 2025 17:10
@ibraheemdev ibraheemdev force-pushed the ibraheem/update-salsa branch from 206a58f to d9b1a64 Compare July 30, 2025 17:10
@github-actions
Copy link
Contributor

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@ibraheemdev ibraheemdev marked this pull request as ready for review July 30, 2025 17:51
@ibraheemdev ibraheemdev merged commit f6b7418 into main Jul 30, 2025
38 checks passed
@ibraheemdev ibraheemdev deleted the ibraheem/update-salsa branch July 30, 2025 19:31
dcreager added a commit that referenced this pull request Aug 1, 2025
* main: (39 commits)
  [ty] Initial test suite for `TypedDict` (#19686)
  [ty] Improve debuggability of protocol types (#19662)
  [ty] Simplify lifetime requirements for `PySlice` trait (#19687)
  [ty] Improve `isinstance()` truthiness analysis for generic types (#19668)
  [`refurb`] Make example error out-of-the-box (`FURB164`) (#19673)
  Fix link: unused_import.rs (#19648)
  [ty] Remove `Specialization::display` (full) (#19682)
  [ty] Remove `KnownModule::is_enum` (#19681)
  [ty] Support `__setitem__` and improve `__getitem__` related diagnostics (#19578)
  [ty] Sync vendored typeshed stubs (#19676)
  [`flake8-use-pathlib`] Expand `PTH201` to check all `PurePath` subclasses (#19440)
  [`refurb`] Make example error out-of-the-box (`FURB180`) (#19672)
  [`pyupgrade`] Prevent infinite loop with `I002` (`UP010`, `UP035`) (#19413)
  [ty] Improve the `Display` for generic `type[]` types (#19667)
  [ty] Refactor `TypeInferenceBuilder::infer_subscript_expression_types` (#19658)
  Fix tests on 32-bit architectures (#19652)
  [ty] Move `pandas-stubs` to bad.txt (#19659)
  [ty] Remove special casing for string-literal-in-tuple `__contains__` (#19642)
  Update pre-commit's `ruff` id (#19654)
  Update salsa (#19449)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants