[flake8-blind-except] Change BLE001 to permit logging.critical(..., exc_info=True).

[clockback]

Summary

Changing BLE001 (blind-except) so that it does not flag except clauses which include logging.critical(..., exc_info=True).

Test Plan

It passes the following (whereas the main branch does not):

$ cargo run -p ruff -- check somefile.py --no-cache --select=BLE001

# somefile.py

import logging


try:
    print("Hello world!")
except Exception:
    logging.critical("Did not run.", exc_info=True)

Related: #19519

[ntBre]

Thanks! This makes sense to me. @MichaReiser does this need to go out in preview? blind-except (BLE001) is a stable rule.

I just had one minor docs nit, and could we add a test case or two? Maybe one example with exc_info without a lint and one without exc_info with a lint. These could go at the end of this file and basically be copies of the error case here:

ruff/crates/ruff_linter/resources/test/fixtures/flake8_blind_except/BLE.py

Lines 91 to 94 in d13228a

	try:
	pass
	except Exception:
	logging.error("...", exc_info=True)

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[MichaReiser]

Thanks! This makes sense to me. @MichaReiser does this need to go out in preview? blind-except (BLE001) is a stable rule.

Our versioning policy is a bit vague here:

• The scope of a stable rule is significantly increased
• The intent of the rule changes

Given that this reduce violations, I'd say it's probably okay but it might be good to do a quick grep for # noqa: BLE001 to see if you can find any suppressions specifically for this pattern. If there are many -> preview, otherwise go ahead

[ntBre]

I went through two pages of search results on GitHub and didn't find any instances of this pattern. Along with the clean ecosystem report, I think this is good to go once we add tests.

[ntBre]

Thank you!