Skip to content

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Sep 4, 2025

The tests looked good. For the docs, I added a ## See also section pointing to
the closely-related F841 (unused-variable) and the corresponding section to F841
pointing back to RUF059. It seems like you'd probably want both of these active
or at least to know about the other when reading the docs.

The tests looked good. For the docs, I added a `## See also` section pointing to
the closely-related F841 (unused-variable) and the corresponding section to F841
pointing back to RUF059. It seems like you'd probably want both of these active
or at least to know about the other when reading the docs.
@ntBre ntBre added this to the v0.13 milestone Sep 4, 2025
@ntBre ntBre added the rule Implementing or modifying a lint rule label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+983 -3 violations, +0 -0 fixes in 22 projects; 33 projects unchanged)

RasaHQ/rasa (+39 -0 violations, +0 -0 fixes)

+ rasa/telemetry.py:594:30: RUF059 Unpacked variable `tb` is never used
+ rasa/telemetry.py:594:9: RUF059 Unpacked variable `exc_type` is never used
+ tests/cli/test_rasa_export.py:278:5: RUF059 Unpacked variable `events` is never used
+ tests/core/evaluation/test_marker.py:287:13: RUF059 Unpacked variable `expected` is never used
+ tests/core/evaluation/test_marker.py:307:13: RUF059 Unpacked variable `expected` is never used
+ tests/core/evaluation/test_marker.py:558:13: RUF059 Unpacked variable `expected_size` is never used
+ tests/core/evaluation/test_marker.py:583:13: RUF059 Unpacked variable `expected_size` is never used
+ tests/core/test_evaluation.py:152:23: RUF059 Unpacked variable `num_stories` is never used
+ tests/core/test_evaluation.py:319:23: RUF059 Unpacked variable `num_stories` is never used
+ tests/core/training/test_interactive.py:818:11: RUF059 Unpacked variable `kwargs` is never used
... 29 additional changes omitted for project

apache/airflow (+107 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ airflow-core/src/airflow/api_fastapi/execution_api/deps.py:140:21: RUF059 Unpacked variable `exc` is never used
+ airflow-core/src/airflow/configuration.py:1667:22: RUF059 Unpacked variable `source` is never used
+ airflow-core/src/airflow/configuration.py:725:25: RUF059 Unpacked variable `should_continue` is never used
+ airflow-core/src/airflow/executors/local_executor.py:223:25: RUF059 Unpacked variable `exc` is never used
+ airflow-core/src/airflow/jobs/scheduler_job_runner.py:1092:21: RUF059 Unpacked variable `sep` is never used
+ airflow-core/src/airflow/providers_manager.py:925:13: RUF059 Unpacked variable `module` is never used
+ airflow-core/src/airflow/providers_manager.py:925:21: RUF059 Unpacked variable `class_name` is never used
+ airflow-core/src/airflow/ti_deps/deps/ready_to_reschedule.py:49:9: RUF059 Unpacked variable `executor` is never used
+ airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py:664:17: RUF059 Unpacked variable `asset2` is never used
+ airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py:664:9: RUF059 Unpacked variable `asset1` is never used
... 97 additional changes omitted for project

apache/superset (+16 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ scripts/check-env.py:67:24: RUF059 Unpacked variable `supported_max` is never used
+ superset/commands/report/alert.py:173:13: RUF059 Unpacked variable `executor` is never used
+ superset/models/core.py:770:9: RUF059 Unpacked variable `cursor` is never used
+ tests/integration_tests/core_tests.py:284:21: RUF059 Unpacked variable `tests` is never used
+ tests/integration_tests/core_tests.py:871:9: ANN201 Missing return type annotation for public function `test_lang_redirect`
- tests/integration_tests/core_tests.py:871:9: ANN201 Missing return type annotation for public function `test_lang_redirect`
+ tests/integration_tests/dict_import_export_tests.py:168:9: RUF059 Unpacked variable `table` is never used
+ tests/integration_tests/dict_import_export_tests.py:173:9: RUF059 Unpacked variable `table_over` is never used
... 8 additional changes omitted for rule RUF059
+ tests/integration_tests/utils_tests.py:381:9: ANN201 Missing return type annotation for public function `test_schema_one_of_case_insensitive`
- tests/integration_tests/utils_tests.py:381:9: ANN201 Missing return type annotation for public function `test_schema_one_of_case_insensitive`
... 9 additional changes omitted for project

binary-husky/gpt_academic (+58 -0 violations, +0 -0 fixes)

+ crazy_functions/Conversation_To_File.py:223:9: RUF059 Unpacked variable `html` is never used
+ crazy_functions/Dynamic_Function_Generate.py:195:19: RUF059 Unpacked variable `installation_advance` is never used
+ crazy_functions/Latex_Function.py:382:18: RUF059 Unpacked variable `downloaded` is never used
+ crazy_functions/Mermaid_Figure_Gen.py:327:35: RUF059 Unpacked variable `page_one` is never used
+ crazy_functions/Social_Helper.py:70:17: RUF059 Unpacked variable `err_msg` is never used
+ crazy_functions/Vectorstore_QA.py:107:5: RUF059 Unpacked variable `resp` is never used
+ crazy_functions/agent_fns/python_comment_agent.py:216:9: RUF059 Unpacked variable `begin` is never used
+ crazy_functions/crazy_utils.py:122:21: RUF059 Unpacked variable `p_ratio` is never used
+ crazy_functions/crazy_utils.py:269:21: RUF059 Unpacked variable `p_ratio` is never used
+ crazy_functions/crazy_utils.py:606:13: RUF059 Unpacked variable `stdout` is never used
... 48 additional changes omitted for project

bokeh/bokeh (+25 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ src/bokeh/sphinxext/bokeh_model.py:121:34: RUF059 Unpacked variable `arglist` is never used
+ src/bokeh/sphinxext/bokeh_model.py:121:43: RUF059 Unpacked variable `retann` is never used
+ src/bokeh/sphinxext/bokeh_model.py:121:9: RUF059 Unpacked variable `name_prefix` is never used
+ src/bokeh/sphinxext/bokeh_options.py:108:36: RUF059 Unpacked variable `arglist` is never used
+ src/bokeh/sphinxext/bokeh_options.py:108:45: RUF059 Unpacked variable `retann` is never used
+ src/bokeh/sphinxext/bokeh_options.py:108:9: RUF059 Unpacked variable `name_prefix` is never used
+ src/bokeh/sphinxext/bokeh_plot.py:254:15: RUF059 Unpacked variable `lineno` is never used
+ src/bokeh/sphinxext/bokeh_settings.py:84:32: RUF059 Unpacked variable `arglist` is never used
+ src/bokeh/sphinxext/bokeh_settings.py:84:41: RUF059 Unpacked variable `retann` is never used
+ src/bokeh/sphinxext/bokeh_settings.py:84:9: RUF059 Unpacked variable `name_prefix` is never used
... 15 additional changes omitted for project

ibis-project/ibis (+2 -0 violations, +0 -0 fixes)

+ ibis/backends/tests/test_set_ops.py:40:12: RUF059 Unpacked variable `c` is never used
+ ibis/backends/tests/test_set_ops.py:40:25: RUF059 Unpacked variable `dc` is never used

langchain-ai/langchain (+5 -0 violations, +0 -0 fixes)

+ libs/langchain/langchain/agents/openai_assistant/base.py:511:22: RUF059 Unpacked variable `last_output` is never used
+ libs/langchain/langchain/agents/openai_assistant/base.py:668:22: RUF059 Unpacked variable `last_output` is never used
+ libs/langchain/langchain/chains/combine_documents/reduce.py:256:22: RUF059 Unpacked variable `extra_return_dict` is never used
+ libs/langchain/langchain/chains/combine_documents/reduce.py:290:22: RUF059 Unpacked variable `extra_return_dict` is never used
+ libs/langchain/langchain/evaluation/criteria/eval_chain.py:103:17: RUF059 Unpacked variable `reasoning` is never used

latchbio/latch (+2 -0 violations, +0 -0 fixes)

+ src/latch_cli/services/test_data/remove.py:23:44: RUF059 Unpacked variable `account_id` is never used
+ src/latch_cli/snakemake/workflow.py:295:9: RUF059 Unpacked variable `val` is never used

lnbits/lnbits (+1 -0 violations, +0 -0 fixes)

+ tests/api/test_api.py:373:5: RUF059 Unpacked variable `fake_data` is never used

milvus-io/pymilvus (+91 -0 violations, +0 -0 fixes)

+ examples/orm/collection.py:139:5: RUF059 Unpacked variable `raw_vectors` is never used
+ tests/test_grpc_handler.py:119:10: RUF059 Unpacked variable `invocation_metadata` is never used
+ tests/test_grpc_handler.py:119:31: RUF059 Unpacked variable `request` is never used
+ tests/test_grpc_handler.py:137:10: RUF059 Unpacked variable `invocation_metadata` is never used
+ tests/test_grpc_handler.py:137:31: RUF059 Unpacked variable `request` is never used
+ tests/test_grpc_handler.py:22:10: RUF059 Unpacked variable `invocation_metadata` is never used
+ tests/test_grpc_handler.py:22:31: RUF059 Unpacked variable `request` is never used
+ tests/test_grpc_handler.py:335:10: RUF059 Unpacked variable `invocation_metadata` is never used
+ tests/test_grpc_handler.py:335:31: RUF059 Unpacked variable `request` is never used
+ tests/test_grpc_handler.py:362:10: RUF059 Unpacked variable `invocation_metadata` is never used
... 81 additional changes omitted for project

pandas-dev/pandas (+83 -0 violations, +0 -0 fixes)

+ doc/make.py:81:9: RUF059 Unpacked variable `base_name` is never used
+ doc/source/conf.py:623:18: RUF059 Unpacked variable `parent` is never used
+ doc/source/conf.py:623:26: RUF059 Unpacked variable `modname` is never used
+ pandas/core/_numba/kernels/mean_.py:174:23: RUF059 Unpacked variable `comp_arr` is never used
+ pandas/core/_numba/kernels/sum_.py:235:23: RUF059 Unpacked variable `comp_arr` is never used
+ pandas/core/apply.py:1098:19: RUF059 Unpacked variable `kwargs` is never used
+ pandas/core/apply.py:1267:15: RUF059 Unpacked variable `kwargs` is never used
+ pandas/core/apply.py:1409:15: RUF059 Unpacked variable `kwargs` is never used
+ pandas/core/arrays/datetimelike.py:1116:19: RUF059 Unpacked variable `o_mask` is never used
+ pandas/core/arrays/datetimelike.py:1179:19: RUF059 Unpacked variable `o_mask` is never used
... 73 additional changes omitted for project

pypa/build (+3 -0 violations, +0 -0 fixes)

+ tests/test_main.py:141:10: RUF059 Unpacked variable `err` is never used
+ tests/test_main.py:345:13: RUF059 Unpacked variable `stderr` is never used
+ tests/test_projectbuilder.py:427:10: RUF059 Unpacked variable `err` is never used

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (3 rules affected)

code total + violation - violation + fix - fix
RUF059 980 980 0 0 0
ANN201 4 2 2 0 0
D212 2 1 1 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre
Copy link
Contributor Author

ntBre commented Sep 4, 2025

I went through the ecosystem check subset linked in the PR, and these all look correct to me. There are a lot of hits, but the rule also has an autofix to add a _ to the variable name, which seems very helpful.

@ntBre ntBre marked this pull request as ready for review September 4, 2025 16:42
@ntBre ntBre requested a review from dylwil3 September 4, 2025 16:42
@ntBre ntBre merged commit 56bca1a into brent/0.13.0 Sep 4, 2025
35 checks passed
@ntBre ntBre deleted the brent/ruf059 branch September 4, 2025 20:20
@ntBre ntBre mentioned this pull request Sep 4, 2025
2 tasks
ntBre added a commit that referenced this pull request Sep 8, 2025
The tests looked good. For the docs, I added a `## See also` section
pointing to
the closely-related F841 (unused-variable) and the corresponding section
to F841
pointing back to RUF059. It seems like you'd probably want both of these
active
or at least to know about the other when reading the docs.
ntBre added a commit that referenced this pull request Sep 10, 2025
The tests looked good. For the docs, I added a `## See also` section
pointing to
the closely-related F841 (unused-variable) and the corresponding section
to F841
pointing back to RUF059. It seems like you'd probably want both of these
active
or at least to know about the other when reading the docs.
ntBre added a commit that referenced this pull request Sep 10, 2025
The tests looked good. For the docs, I added a `## See also` section
pointing to
the closely-related F841 (unused-variable) and the corresponding section
to F841
pointing back to RUF059. It seems like you'd probably want both of these
active
or at least to know about the other when reading the docs.
ntBre added a commit that referenced this pull request Sep 10, 2025
The tests looked good. For the docs, I added a `## See also` section
pointing to
the closely-related F841 (unused-variable) and the corresponding section
to F841
pointing back to RUF059. It seems like you'd probably want both of these
active
or at least to know about the other when reading the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants