Skip to content

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Sep 4, 2025

Tests and docs look good

@ntBre ntBre added this to the v0.13 milestone Sep 4, 2025
@ntBre ntBre added the rule Implementing or modifying a lint rule label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -4 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

python-trio/trio (+0 -4 violations, +0 -0 fixes)

- src/trio/_core/_tests/test_mock_clock.py:115:26: RUF100 [*] Unused `noqa` directive (non-enabled: `ASYNC116`)
- src/trio/_core/_tests/test_mock_clock.py:97:26: RUF100 [*] Unused `noqa` directive (non-enabled: `ASYNC116`)
- src/trio/_tests/test_ssl.py:717:39: RUF100 [*] Unused `noqa` directive (non-enabled: `ASYNC116`)
- src/trio/_tests/test_ssl.py:742:39: RUF100 [*] Unused `noqa` directive (non-enabled: `ASYNC116`)

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF100 4 0 4 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre
Copy link
Contributor Author

ntBre commented Sep 4, 2025

The ecosystem changes are previously-unused noqa codes for ASYNC116 that are now used on stable. I took a look at these to see where a real project needed to use a noqa for this rule, but it was just trio intentionally testing long sleeps, with comments to support that:

    # ignore ASYNC116, not sleep_forever, trying to test a large but finite sleep
    await sleep(100000)  # noqa: ASYNC116

@ntBre ntBre marked this pull request as ready for review September 4, 2025 18:38
@ntBre ntBre requested a review from dylwil3 September 4, 2025 18:38
@ntBre ntBre merged commit 578e96e into brent/0.13.0 Sep 4, 2025
36 checks passed
@ntBre ntBre deleted the brent/async116 branch September 4, 2025 20:18
@ntBre ntBre mentioned this pull request Sep 4, 2025
2 tasks
ntBre added a commit that referenced this pull request Sep 8, 2025
ntBre added a commit that referenced this pull request Sep 10, 2025
ntBre added a commit that referenced this pull request Sep 10, 2025
ntBre added a commit that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants