Skip to content

[ty] Require that implementors of Constraints also implement Debug #20348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

[ty] Require that implementors of Constraints also implement Debug #20348

merged 2 commits into from
Sep 11, 2025

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Sep 11, 2025

The debug representation isn't as useful as calling .display(db), but it's still kind-of annoying when dbg!() calls don't compile locally due to the compiler not being able to guarantee that an object of type impl Constraints implements Debug

@AlexWaygood
[ty] Require that implementors of Constraints also implement Debug
6ffd23f 
The debug representation isn't as useful as calling `.display(db)`, but it's still kind-of annoying when `dbg!()` calls don't compile locally due to the compiler not being able to guarantee that an object of type `impl Constraints` implements `Debug`
@AlexWaygood AlexWaygood added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Sep 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@AlexWaygood AlexWaygood merged commit 89f1746 into main Sep 11, 2025
38 checks passed
@AlexWaygood AlexWaygood deleted the alex/contraints-dbg branch September 11, 2025 13:34
dcreager added a commit that referenced this pull request Sep 11, 2025
@dcreager
Merge remote-tracking branch 'origin/main' into dcreager/object-variant
b411f23 
* origin/main:
  [ty] Minor fixes to `Protocol` tests (#20347)
  [ty] use Type::Divergent to avoid panic in infinitely-nested-tuple implicit attribute (#20333)
  [ty] Require that implementors of `Constraints` also implement `Debug` (#20348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcreager dcreager dcreager approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

Assignees

No one assigned

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood @dcreager