[ty] Remove Self from generic context when binding Self
#20364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
sharkdp
force-pushed
the
david/remove-self-from-generic-context
branch
2 times, most recently
from
3dd2ab5 to
0c7ca15
Compare
sharkdp
changed the base branch from
main
to
david/patch-self-on-fallback-types
sharkdp
requested review from
AlexWaygood,
carljm and
dcreager
as code owners
Contributor
|
sharkdp
force-pushed
the
david/remove-self-from-generic-context
branch
from
0c7ca15 to
1d09aae
Compare
Contributor
Author
You told me that this is might be a problem :-) |
Member
And then promptly forgot to look for it in #20328 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This mainly removes an internal inconsistency, where we didn't remove the
Selftype variable when eagerly bindingSelfto an instance type. It has no observable effect, apparently.builds on top of #20328
Test Plan
None