Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Sep 15, 2025

Reverts #20409

Prior to 25c13ea, the walltime benchmarks CI job took around 10-11 minutes. It now seems to be taking around 17-18 minutes to complete, which is a pretty major slowdown and somewhat annoying if you're waiting for benchmark results on a PR! See e.g. https://github.com/astral-sh/ruff/actions/runs/17738649543/job/50411336184

@AlexWaygood AlexWaygood added the internal An internal refactor or improvement label Sep 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@silamon
Copy link
Contributor

silamon commented Sep 16, 2025

Maybe try running with environment variable CODSPEED_PERF_ENABLED=false, since it has been enabled by default, while it was not before.

uses: CodSpeedHQ/action@653fdc30e6c40ffd9739e40c8a0576f4f4523ca1 # v4.0.1
uses: CodSpeedHQ/action@76578c2a7ddd928664caa737f0e962e3085d4e7c # v3.8.1
with:
mode: instrumentation
Copy link
Member

@MichaReiser MichaReiser Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the mode lines, it makes upgrading easier (a rennovate PR rather than having to do the upgrade manually)

@MichaReiser
Copy link
Member

I pinged the codspeed folks. I'd suggest to maybe give them a few hours to fix this on their side.

@MichaReiser
Copy link
Member

I think @silamon is on to something. Codspeed now enables perf profiles for wallspeed benchmarks (you now see a flamegraph for walltime benchmarks too). I can't say just yet if they'll be useful or if our flamegraphs are too large but it's certainly nice to have more than just: It got slower or faster

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try CODSPEED_PERF_ENABLED=false or accept the regression in return for now having flamegraphs

@AlexWaygood
Copy link
Member Author

https://codspeed.io/astral-sh/ruff/branches/alex%2Fsubtyping-between-protocols?runnerMode=WallTime has some flamegraphs for #20368 (comment) but I don't find them useful personally. The regression in CI time is very significant, however; I'm finding it very frustrating waiting for CI to finish on #20368!

We should try CODSPEED_PERF_ENABLED=false

I've pushed a commit trying this out

@AlexWaygood
Copy link
Member Author

Nice, we're back to the walltime benchmarks completing in 10-11 minutes. Though there are now a lot of lines like this in the logs that I don't know the meaning of:

  Failed to send benchmark URI to runner: FIFO does not exist: /tmp/runner.ctl.fifo

@AlexWaygood AlexWaygood changed the title Revert "Update CodSpeedHQ/action action to v4" Disable flamegraph uploads for walltime benchmarks Sep 16, 2025
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'm fine disabling this for now. It might be worth adding a comment explaining why we disable the perf uploads (because they would be nice)

@AlexWaygood AlexWaygood enabled auto-merge (squash) September 16, 2025 09:04
@AlexWaygood AlexWaygood merged commit e6b321e into main Sep 16, 2025
34 checks passed
@AlexWaygood AlexWaygood deleted the revert-20409-renovate/codspeedhq-action-4.x branch September 16, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants