[ty] Fix incorrect inference of enum.auto() for enums with non-int mixins, and imprecise inference of enum.auto() for single-member enums
#20541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
thejchap
force-pushed
the
thejchap/enum-auto2
branch
2 times, most recently
from
7208cf6 to
87548a3
Compare
thejchap
force-pushed
the
thejchap/enum-auto2
branch
2 times, most recently
from
184c132 to
eb5cf24
Compare
thejchap
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
thejchap
force-pushed
the
thejchap/enum-auto2
branch
from
eb5cf24 to
fc0bd30
Compare
thejchap
force-pushed
the
thejchap/enum-auto2
branch
5 times, most recently
from
e1d9024 to
d24b83b
Compare
thejchap
force-pushed
the
thejchap/enum-auto2
branch
from
d24b83b to
b69c358
Compare
Contributor
Author
|
@AlexWaygood i think this is ready for another look! |
AlexWaygood
changed the title
enum.auto() casesenum.auto() for enums with non-int mixins, and imprecise inference of enum.auto() for single-member enums
Member
|
@woodruffw, any idea why astral-bot isn't posting or editing any ecosystem-report comments on this PR? :-) I'd love to double-check the ecosystem impact here before merging |
Member
|
(Just synchronizing chat streams) Yeah, I have a theory on what's causing this -- I've opened a tracking issue on the bot! |
Member
|
I've made a tentative fix for this, which is now in place -- I'm going to fast-forward this branch to confirm that it works. Edit: appears to be working! |
dcreager
added a commit
that referenced
this pull request
Nov 11, 2025
* origin/main: (38 commits) [ty] Make implicit submodule imports only occur in global scope (#21370) [ty] introduce local variables for `from` imports of submodules in `__init__.py(i)` (#21173) [`ruff`] Ignore `str()` when not used for simple conversion (`RUF065`) (#21330) [ty] implement `typing.NewType` by adding `Type::NewTypeInstance` [ty] supress inlay hints for `+1` and `-1` (#21368) [ty] Use type context for inference of generic constructors (#20933) [ty] Improve generic call expression inference (#21210) [ty] supress some trivial expr inlay hints (#21367) [`configuration`] Fix unclear error messages for line-length values exceeding `u16::MAX` (#21329) [ty] Fix incorrect inference of `enum.auto()` for enums with non-`int` mixins, and imprecise inference of `enum.auto()` for single-member enums (#20541) [`refurb`] Detect empty f-strings (`FURB105`) (#21348) [ty] provide `import` completion when in `from <name> <name>` statement (#21291) [ty] elide redundant inlay hints for function args (#21365) Fix syntax error false positive on alternative `match` patterns (#21362) Add a new "Opening a PR" section to the contribution guide (#21298) [`flake8-simplify`] Fix SIM222 false positive for `tuple(generator) or None` (`SIM222`) (#21187) Rebuild ruff binary instead of sharing it across jobs (#21361) [ty] Fix `--exclude` and `src.exclude` merging (#21341) [ty] Add support for properties that return `Self` (#21335) Add upstream linter URL to `ruff linter --output-format=json` (#21316) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ty#1241
.valueon single member enumsAny)Test Plan
new mdtests