[ty] Reformulation of public symbol inference test suite #20667
Merged
+86
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
added
testing
sharkdp
force-pushed
the
david/reformulate-public-symbol-test-suite
branch
from
7e9a2f1 to
1c2c35e
Compare
sharkdp
commented
Oct 1, 2025
| # Modifications allowed in this case: | ||
| a = None | ||
| # Modification attempts yield an error: | ||
| # error: [unresolved-attribute] |
Contributor
Author
There was a problem hiding this comment.
This is the only behavioral change. It makes sense that we emit an error for class scopes. For the module-global scope, "modifying a" was just creating a new variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reformulation of the public symbol type inference test suite to use class scopes instead of module scopes. This is in preparation for an upcoming change to module-global scopes (#20664).
Test Plan
Updated tests