Skip to content

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Oct 8, 2025

Summary

The types module currently re-exports a lot of functions and data types from types::ide_support. One of these is called Member, a name that is overloaded several times already. And I'd like to add one more Member struct soon. Making the whole ide_support module public seems cleaner to me, anyway.

Test Plan

Pure refactoring.

@sharkdp sharkdp requested a review from carljm as a code owner October 8, 2025 15:27
@sharkdp sharkdp added the internal An internal refactor or improvement label Oct 8, 2025
@sharkdp sharkdp added the ty Multi-file analysis & type inference label Oct 8, 2025
@sharkdp sharkdp changed the title [ty] Encapsulate ide_support module [ty] Do not re-export ide_support attributes from types Oct 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

mypy_primer results

Changes were detected when running on open source projects
scikit-build-core (https://github.com/scikit-build/scikit-build-core)
+ src/scikit_build_core/build/_wheelfile.py:51:22: error[no-matching-overload] No overload of function `field` matches arguments
- Found 52 diagnostics
+ Found 53 diagnostics
No memory usage changes detected ✅

@sharkdp sharkdp merged commit 697998f into main Oct 8, 2025
42 checks passed
@sharkdp sharkdp deleted the david/ide-support-refactor branch October 8, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants