[ty] Add --no-progress option
#21063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
cli
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
MichaReiser
requested review from
carljm,
dcreager and
sharkdp
as code owners
Contributor
|
zanieb
approved these changes
Oct 24, 2025
zanieb
reviewed
Oct 24, 2025
Comment on lines
-16
to
+15
| pub(crate) fn with_verbosity(self, verbosity: VerbosityLevel) -> Self { | ||
| pub(crate) fn new(verbosity: VerbosityLevel, no_progress: bool) -> Self { |
Member
There was a problem hiding this comment.
crushed that you changed my API :)
Member
Author
There was a problem hiding this comment.
Sorry. I still very much like the Printer API overall. It's nice to have something that's responsible to make these kind of decisions. I hope that makes up for my API change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
--no-progressoption to suppress the progress bar (matching uv's interface)Test Plan
I don't think it's possible to test this in our snapshot tests because the progress bar gets hidden for non-interactive terminals.
Screen.Recording.2025-10-24.at.16.07.32.mov