[pylint] Fix PLR1708 false positives on nested functions

[chirizxc]

Summary

Fixes #21162

Test Plan

cargo nextest run pylint

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[ntBre]

Thanks for working on this, but I think the fix here is too simplistic, and we actually need to be traversing scopes. As one example, this code triggers the runtime error in CPython but is no longer flagged by the rule:

>>> def h():
...     yield 1
...     class C:
...         raise StopIteration
...     yield C
...
... for i in h(): ...
...
Ellipsis
Traceback (most recent call last):
  File "<python-input-0>", line 3, in h
    class C:
        raise StopIteration
  File "<python-input-0>", line 4, in C
    raise StopIteration
StopIteration

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<python-input-0>", line 7, in <module>
    for i in h(): ...
             ~^^
RuntimeError: generator raised StopIteration

I'm wondering if we should just run the rule on StmtFunctionDefs instead of raise statements and then check for both yield and raise StopIteration while visiting the function body, but I haven't thought about it much more than that.

[ntBre]

Thanks! This looks good to me now, I just had a couple more minor simplification suggestions.

[ntBre]

Thank you!